From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26031 invoked by alias); 17 Dec 2013 17:48:18 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32143 Received: (qmail 11100 invoked from network); 17 Dec 2013 17:48:13 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=spodhuis.org; s=d201210; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=nP5IqSXgPzIzgmeWEbsemfwcycZwLcKwAOC1CdJLC2c=; b=TM90D0hNeZJ8M9HyZVr16WtPnF2oee81XmVnX8FnYsbNSifxfu2KB8v+PP46J3U/xC+WEtKlaSDwTpJQSTwHTT8frM0I4wCF5xIS/ianZxzLrJtTgKcjmwqS+/sKH4DbaZbY+wGhM5rWpPrwv8ywZq26c5MWDymcdFo9sjb4Hp8=; Date: Tue, 17 Dec 2013 12:48:10 -0500 From: Phil Pennock To: Peter Stephenson Cc: zsh-workers@zsh.org Subject: Re: 5.0.3 +* -> git completion regression Message-ID: <20131217174810.GA82157@redoubt.spodhuis.org> Mail-Followup-To: Peter Stephenson , zsh-workers@zsh.org References: <20131216081436.GA23085@redoubt.spodhuis.org> <20131216094700.2c5edd2a@pwslap01u.europe.root.pri> <20131216103726.GA25715@redoubt.spodhuis.org> <20131216220845.2108e18b@pws-pc.ntlworld.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131216220845.2108e18b@pws-pc.ntlworld.com> OpenPGP: url=https://www.security.spodhuis.org/PGP/keys/0x3903637F.asc On 2013-12-16 at 22:08 +0000, Peter Stephenson wrote: > Thanks. This is an efficient fix, so I hope it's good enough --- I've > added a regression test, and it seems to be. > > Another good workout with some sh scripts or functions would be useful. Appears to work for me in practice; while I haven't tested extensively (I don't have a test suite of all the things I do), one thing did crop up. I was confused over zsh versions after installing with this patch, but config.log shows: configure:14406: WARNING: unrecognized options: --enable-local-patchlevel It looks like it's spelt --enable-custom-patchlevel so the INSTALL file is wrong. >>From 6335389a59f5ec79154923fe8105aad4d846df25 Mon Sep 17 00:00:00 2001 From: Phil Pennock Date: Tue, 17 Dec 2013 12:43:17 -0500 Subject: [PATCH] Fix --enable-custom-patchlevel name in INSTALL --- INSTALL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index 00791cd..99895bd 100644 --- a/INSTALL +++ b/INSTALL @@ -297,7 +297,7 @@ Modified versions of zsh If you are making local modifications to zsh, you are strongly advised to configure with the option - --enable-local-patchlevel="" + --enable-custom-patchlevel="" so that the variable $ZSH_PATCHLEVEL indicates this is not a standard version of the shell. The argument is arbitrary, but should indicate -- 1.8.5.1