zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: Bug#733075: Bug#733075: zsh: command completion not working after semicolon
Date: Thu, 2 Jan 2014 18:16:31 +0000	[thread overview]
Message-ID: <20140102181631.7b390c13@pws-pc.ntlworld.com> (raw)
In-Reply-To: <131225101336.ZM17671@torch.brasslantern.com>

On Wed, 25 Dec 2013 10:13:36 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> I think this is the right thing, but it would be helpful if someone
> can also check that the redirection issue has not regressed.  (There
> are no tests of command completion in Y01, so I'm not sure how to
> add a regression test for these.)

That was a crash when completing after the "<" in

  for f in 1; do < x

which was very easy to reproduce, and that's still working after the
change.

Regression tests for interactive features is another place needing a
volunteer (who wouldn't need to know about internals).  Felix did some
good work on Zle testing but it really needs a permanent maintainer.

get_comp_string() is screaming out for something less ad hoc, but I
don't know what that is apart from rewriting the shell to provide a
partial parse tree for a given context, which isn't going to happen.

pws


  reply	other threads:[~2014-01-02 18:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131224214220.2173519380.qww314159@soup.q.qbilt.org>
2013-12-25  8:19 ` Fwd: [Pkg-zsh-devel] " Richard Hartmann
2013-12-25  8:38   ` Richard Hartmann
     [not found] ` <877gatqlp3.fsf@ft.bewatermyfriend.org>
     [not found]   ` <CAD77+gRdTo6gN-XJWckqy7sn5afE6r5CPsp2E3MqxoWJTdup6Q@mail.gmail.com>
2013-12-25 11:01     ` Bug#733075: " Frank Terbeck
2013-12-25 18:13       ` Bart Schaefer
2014-01-02 18:16         ` Peter Stephenson [this message]
2014-01-02 20:42           ` Bart Schaefer
2014-01-02 21:38           ` Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140102181631.7b390c13@pws-pc.ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).