From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2493 invoked by alias); 2 Jun 2014 18:21:22 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32677 Received: (qmail 24754 invoked from network); 2 Jun 2014 18:21:15 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=mesmtp; bh= Mxhrf9d3vXueMcoi3MAWG0sDv1M=; b=jRIcsIov2ExIfSQ/+2TRER2+ehH/owG7 Ro3XpGo4xpIy/hvDpxLnQNtlySx2HBT4Kmbe8hvxpBpelQE4JvgPNXxWEoXoyfH0 0IeLuN8Q1WSHvuJKp9S81ALbxbz11TjtRA4a/oIzGDVrStVJpiaL2zVIxNx3xKvu dQkzCTzpghc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=smtpout; bh=Mxhrf9d3vXueMcoi3MAWG0sDv1M=; b=i+bNkqRwJqfzMaqbDDqowaw8S95c uLrMl1BOTv186bBONJoSGQG1LDklZkr0o13Ki0sXL4brwHsah4yihZl4jbicGYAm jlOu6yKwlVJt9iMFFDunst+GfsZg37+auYtU6hv1kfU6v8lepv6sNGc8Jk5LyCXQ /Go60TRJf5aRDNg= X-Sasl-enc: N12lspZ5WUdfdqVxBEZV2H9r9F9I2nvi8hSDiLv1sPuR 1401733267 Date: Mon, 2 Jun 2014 18:21:01 +0000 From: Daniel Shahaf To: Frank Terbeck Cc: zsh-workers@zsh.org Subject: Re: [PATCH] vcs_info git: Fix stagedstr for empty repos Message-ID: <20140602182101.GA1858@tarsus.local2> References: <20140601022653.GE1820@tarsus.local2> <87vbsj4tk1.fsf@ft.bewatermyfriend.org> <20140602130028.GD1871@tarsus.local2> <87r4374ffd.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r4374ffd.fsf@ft.bewatermyfriend.org> User-Agent: Mutt/1.5.21 (2010-09-15) Frank Terbeck wrote on Mon, Jun 02, 2014 at 15:19:34 +0200: > Daniel Shahaf wrote: > [...] > >> I'm with Aaron on this one. IIRC, git uses the diff-index command in > >> various places, so I don't think it'll be removed anytime soon. > > > > My concern was not with using diff-index but with using the empty tree. > > Since Aaron says using it would be robust, let's just use it. Attached. > > I see. I suppose this would only change, if git decides to change its > hashing algorithm. That's a problem for another day, I guess. :) Well, the people from the future who run into this problem can try my original patch --- either the ls-files solution it implements, or the hash-object solution it describes in a comment, might work even if the hashing algorithm changes backwards-incompatibly.