zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: segmentation fault with {1..1234567}
Date: Mon, 7 Jul 2014 20:33:12 +0100	[thread overview]
Message-ID: <20140707203312.27566ab8@pws-pc.ntlworld.com> (raw)
In-Reply-To: <140706124629.ZM19578@torch.brasslantern.com>

On Sun, 06 Jul 2014 12:46:29 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> The question is, do we fix this one instance (your patch), do we redefine
> VARARR() [possibly conditionally] to change all the usages at once, or do
> we individually evaluate the 50-odd uses of VARARR()?

Probably the third option is the right one, but it's the most work.  The
other possibilities are the pragmatic option of only fixing things when
they turn out to be buggy, or changing everything to heap allocation (or
something else known not to be problematic).  The best argument for the
last one is that it removes quite a lot of variant behaviour between
systems --- even if using zhalloc() isn't particularly efficient we can
all see whatever effects there are and are in a better position to fix
them (e.g. with appropriate heap manipulation commands).  For that
reason, I'm vaguely wondering if trying out that might not be a
reasonable start.

pws


  parent reply	other threads:[~2014-07-07 22:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 17:25 Vincent Lefevre
2014-07-05  1:40 ` Bart Schaefer
2014-07-05 11:12   ` Vincent Lefevre
2014-07-05 16:57     ` Bart Schaefer
2014-07-05 23:39       ` Vincent Lefevre
2014-07-06  0:09         ` Vincent Lefevre
2014-07-06 19:46           ` Bart Schaefer
2014-07-07  1:12             ` Vincent Lefevre
2014-07-06 16:16         ` Bart Schaefer
2014-07-06 18:30           ` Peter Stephenson
2014-07-06 19:46             ` Bart Schaefer
2014-07-06 22:23               ` Mikael Magnusson
2014-07-07 19:33               ` Peter Stephenson [this message]
2014-07-08  1:08                 ` Bart Schaefer
2014-07-08 10:38                   ` Peter Stephenson
2014-07-24  9:44                     ` Peter Stephenson
2014-07-24 15:35                       ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140707203312.27566ab8@pws-pc.ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).