From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22159 invoked by alias); 14 Aug 2014 08:34:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33000 Received: (qmail 7067 invoked from network); 14 Aug 2014 08:34:47 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f5-b7f776d000003e54-e9-53ec74a2db75 Date: Thu, 14 Aug 2014 09:34:42 +0100 From: Peter Stephenson To: Zsh Hackers' List Subject: Re: zsh 5.0.5-dev-2 Message-id: <20140814093442.1a74c5b7@pwslap01u.europe.root.pri> In-reply-to: <29575.1407969294@thecus.kiddle.eu> References: <20140812212920.67dcb116@pws-pc.ntlworld.com> <29575.1407969294@thecus.kiddle.eu> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42I5/e/4Nd1FJW+CDT7v0bc42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGXf7XrMXrGOvaHqi1MB4ibWLkYNDQsBEonmGbhcjJ5ApJnHh 3nq2LkYuDiGBpYwSv7/fYgVJCAksZ5JoeWULYrMIqEocaJ3LDmKzCRhKTN00mxFkjoiAtkT7 RzGQsLCAjMSn7y1sIDavgL3E4/bPLCA2p4CBROuyBiaIkfESJ57sBbP5BfQlrv79xARxg73E zCtnGCF6BSV+TL4H1sssoCWxeVsTK4QtL7F5zVvmCYwCs5CUzUJSNgtJ2QJG5lWMoqmlyQXF Sem5RnrFibnFpXnpesn5uZsYIcH3dQfj0mNWhxgFOBiVeHhfzH4dLMSaWFZcmXuIUYKDWUmE 903um2Ah3pTEyqrUovz4otKc1OJDjEwcnFINjOte3rsacFV1+62yIh7vwv0Rk7WrRDz9PVt/ /2b4Vrn66Kn+9Y0O71cU1IhLatwyKnvrrKeZu9z15pyTMmd2xM5Jqj/9l5fpMH+11oOLzbOP m/741FK+WXG+IluwL1/55hKJra8yHILSKnw221b3+fJ59dd/Pi1/KPd+ZntQ5VUWld+OK1cm KrEUZyQaajEXFScCAHRRV6EcAgAA On Thu, 14 Aug 2014 00:34:54 +0200 Oliver Kiddle wrote: > The bug reported in 32431 and 32550 is still there. > > Can we perhaps just remove or comment out that one error message for a > release? zsh -fw cd / zsh: path expansion failed, using root directory We certainly need to do something. But if this is the only issue, can't it be straightforwardly fixed like this? diff --git a/Src/utils.c b/Src/utils.c index 998e46a..75fadd5 100644 --- a/Src/utils.c +++ b/Src/utils.c @@ -780,6 +780,8 @@ xsymlink(char *s) { if (*s != '/') return NULL; + if (!s[1]) + return ztrdup("/"); *xbuf = '\0'; xsymlinks(s + 1); if (!*xbuf) { -- Peter Stephenson Principal Software Engineer Tel: +44 (0)1223 434724 Samsung Cambridge Solution Centre St John's House, St John's Innovation Park, Cowley Road, Cambridge, CB4 0DS, UK