From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33004-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 12524 invoked by alias); 14 Aug 2014 09:32:35 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33004
Received: (qmail 7584 invoked from network); 14 Aug 2014 09:32:33 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_HELO_PASS autolearn=ham version=3.3.2
X-AuditID: cbfec7f4-b7f156d0000063c7-aa-53ec822d8262
Date: Thu, 14 Aug 2014 10:32:27 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.5-dev-2
Message-id: <20140814103227.74c7d168@pwslap01u.europe.root.pri>
In-reply-to: <20140814093442.1a74c5b7@pwslap01u.europe.root.pri>
References: <20140812212920.67dcb116@pws-pc.ntlworld.com>
 <29575.1407969294@thecus.kiddle.eu>
 <20140814093442.1a74c5b7@pwslap01u.europe.root.pri>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFuphluLIzCtJLcpLzFFi42I5/e/4FV3dpjfBBlPusVgcbH7I5MDoserg
	B6YAxigum5TUnMyy1CJ9uwSujCvXXAoWcVZcfTufrYGxm72LkZNDQsBEon3tUVYIW0ziwr31
	bF2MXBxCAksZJd4u2c0M4Sxnkrj8cx0zSBWLgKrE350bmUBsNgFDiambZjN2MXJwiAhoS7R/
	FAMJCwvISHz63sIGYvMK2EvMOdwEtoxTwEFi67/bTBAzpzJKrFkNMYdfQF/i6t9PTBBX2EvM
	vHKGEaJZUOLH5HssIDazgJbE5m1NrBC2vMTmNW+ZJzAKzEJSNgtJ2SwkZQsYmVcxiqaWJhcU
	J6XnGuoVJ+YWl+al6yXn525ihITglx2Mi49ZHWIU4GBU4uF9Mft1sBBrYllxZe4hRgkOZiUR
	XueGN8FCvCmJlVWpRfnxRaU5qcWHGJk4OKUaGHPbuicdXlvBc7dENLtA7pHGtFuT3N+pixyU
	n3NpjdGNQydUw7XiIiLi5tVpf+RaMOfGbI3G0OuXagv/609x/i6Zy/CaOeP+yniBiX+YImr2
	Xec2clx8y+r8z9lnNx0uTP62eM+EG0kWEZrtbM6+JrprLC9e/Xgqf4/FiWXKn9qUNIQ4g1x3
	mymxFGckGmoxFxUnAgCCi2ezHwIAAA==

On Thu, 14 Aug 2014 09:34:42 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> On Thu, 14 Aug 2014 00:34:54 +0200
> Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> > The bug reported in 32431 and 32550 is still there.
> > 
> > Can we perhaps just remove or comment out that one error message for a
> > release?
> 
> zsh -fw
> cd /
> zsh: path expansion failed, using root directory
> 
> We certainly need to do something.  But if this is the only issue, can't
> it be straightforwardly fixed like this?

If someone can reassure me that the weird undocumented interaction with
xbuf bypassing parameter passing starts here --- i.e. we are resetting
xbuf here, then xsymlinks fiddles with it and this code looks at the
result --- then I can't see how this change can be wrong as far as it
goes.  The question is, is there more to it?

> diff --git a/Src/utils.c b/Src/utils.c
> index 998e46a..75fadd5 100644
> --- a/Src/utils.c
> +++ b/Src/utils.c
> @@ -780,6 +780,8 @@ xsymlink(char *s)
>  {
>      if (*s != '/')
>  	return NULL;
> +    if (!s[1])
> +	return ztrdup("/");
>      *xbuf = '\0';
>      xsymlinks(s + 1);
>      if (!*xbuf) {

pws