From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33015-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 9738 invoked by alias); 15 Aug 2014 08:38:22 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33015
Received: (qmail 13501 invoked from network); 15 Aug 2014 08:38:07 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_HELO_PASS autolearn=ham version=3.3.2
X-AuditID: cbfec7f5-b7f776d000003e54-4c-53edc6ea0af4
Date: Fri, 15 Aug 2014 09:38:01 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.5-dev-2
Message-id: <20140815093801.501a465d@pwslap01u.europe.root.pri>
In-reply-to: <140814214412.ZM4177@torch.brasslantern.com>
References: <20140812212920.67dcb116@pws-pc.ntlworld.com>
 <29575.1407969294@thecus.kiddle.eu>
 <20140814093442.1a74c5b7@pwslap01u.europe.root.pri>
 <20140814103227.74c7d168@pwslap01u.europe.root.pri>
 <140814092045.ZM18007@torch.brasslantern.com>
 <20140814205429.44baf512@pws-pc.ntlworld.com>
 <140814214412.ZM4177@torch.brasslantern.com>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFuphluLIzCtJLcpLzFFi42I5/e/4Nd1Xx94GG7zaqmZxsPkhkwOjx6qD
	H5gCGKO4bFJSczLLUov07RK4Mu48+s1SsISt4vJb3QbG/yxdjJwcEgImEvOOvGGFsMUkLtxb
	z9bFyMUhJLCUUeJpxwkmCGc5k8ScDTPBqlgEVCW+PtnGCGKzCRhKTN00G8jm4BAR0JZo/ygG
	EhYWkJH49L2FDcTmFbCX2N3WCNbKKWApsevESXaImbeAZj6dxASS4BfQl7j69xMTxBX2EjOv
	nGGEaBaU+DH5HtilzAJaEpu3NbFC2PISm9e8ZZ7AKDALSdksJGWzkJQtYGRexSiaWppcUJyU
	nmukV5yYW1yal66XnJ+7iRESgl93MC49ZnWIUYCDUYmHV2Prm2Ah1sSy4srcQ4wSHMxKIrxJ
	c98GC/GmJFZWpRblxxeV5qQWH2Jk4uCUamAsroxiMDkXqrIlK+vBnsb043ne7FnBa542t02+
	ccHJ4/OqZE7zHi5hCwklRnF2J4sbzksXXnn60zk7nHH9vS2i3i88njHs+JxnoR18luVmI2P+
	3+usZx5t3bvaNdw54THftLs6Ro0H1t7dMunam4yZ7LZ7qr6XHQ97lthg0Mn8V2Xb5gM3v9Qp
	sRRnJBpqMRcVJwIAi3ScEh8CAAA=

On Thu, 14 Aug 2014 21:44:12 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Maybe just make xsymlinks() have a ternary return value instead of a
> boolean one, and return an actual error value in the case where we've
> truncated on overflow instead of as part of normal expansion to root?

Sounds reasonable for now.  Thanks.

> I don't know if all of these changes are necessary.  It has always
> bothered me that the return value of the recursive calls to xsymlinks()
> are ignored, but maybe this isn't the right way to handle them.

Yes, the way the calls a nested is a bit of a mess.

> Incidentally, anybody recall what the obviously obsolete comment above
> the xsymlinks() definition in Src/utils.c is about?

No, I noticed that but don't remember the history.

pws