From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33155-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 12770 invoked by alias); 13 Sep 2014 07:35:24 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33155
Received: (qmail 13469 invoked from network); 13 Sep 2014 07:35:22 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:cc:subject:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=DfToWuLrL+x18YJsLhmlF/9TtB5ELNz6XosVP0yXMlY=;
        b=LTwAXLcUngFV1XTMdKwzUbk1kApoRa6/h2keIMZLapj1+DiUZrUr/xTH815pkX4OJm
         GomgjUYNhU+bIbvGvXdRbkT+4dgIamEznsp18X12LAGWUSecAS5+Dn7/ELFDHbklYi97
         3qNpgaKtsIo1x3nI79qnmyiuOg+JBMPnkEPS70aNv71ve+t8FiFGAtaJZLF84r2dSFiA
         HSo/2rH1GiYXKtuYKKkvSVrd4QtEg/Fd5dPGXOAm0/jFPv0+wxE/9B1sUoqp3Eupg7Af
         TjMVFqkEBFpdYdil4EalMfk93dS8MN2LnfkpfXhCgGO49tFRcUB2EbRSo20BVPkr62X8
         1+yQ==
X-Received: by 10.180.198.228 with SMTP id jf4mr3515601wic.83.1410593715913;
        Sat, 13 Sep 2014 00:35:15 -0700 (PDT)
Date: Sat, 13 Sep 2014 09:35:14 +0200
From: Marc Finet <m.dreadlock@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: Misc patches for git completion and vcs_info
Message-Id: <20140913093514.03c72e9e4787b4ed7fff7044@gmail.com>
In-Reply-To: <140912165046.ZM23739@torch.brasslantern.com>
References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com>
	<140912165046.ZM23739@torch.brasslantern.com>
X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.24; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

The Fri, 12 Sep 2014 16:50:46 -0700, Bart Schaefer
<schaefer@brasslantern.com> wrote 

> On Sep 12, 11:30pm, Marc Finet wrote:
> }
> } Below is a list of patches that i added in my current zsh (based
> on } tonight's master). Please consider them for review as my
> zsh-level is } currently very low (e.g. patch 2) and i might have
> broken other use-cases } (patch 4 for instance makes me a little
> bit nervous as it seems to easy).
> 
> (I think you left out the list.)
My bad, i'm not yet fluent with git send-email.
 
> I'll leave it to one of the people who more regularly messes with
> VCS_Info to apply these, but here's my brief take on each of them:
> 
> [PATCH 1/9] vcs_info examples: fix typo
> 
>  - no issues with this one
> 
> [PATCH 2/9] completion git: support aliases when \n exist
> 
>  - looks OK, but my "git config" foo is too weak to assess
> 
> PATCH 3/9] vcs_info git: detect revert or cherry-pick with multiple
> commits
> 
>  - no issues
> 
> [PATCH 4/9] vcs_info git: set rrn before using it
> 
>  - seems pretty obvious
> 
> [PATCH 5/9] vcs_info quilt: fix standalone detection
> 
>  - I'm not sure this is correct; do we need to differentiate (( $#
> == 1 )) from [[ -z "$2" ]] ?
Since VCS_INFO_bydir_detect would use the vcs_comm[detect_need_file]:
    for file in ${(s: :)${vcs_comm[detect_need_file]}}; do ...
we have to (re)set it, but i admit that setting it this way (with
a non-existent value) might not be the best way.

> 
> [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory
> 
>  - $(basename $patches) can be replaced with ${patches:t}
Ok (I'll try to remember more parameter expansions).

> [PATCH 7/9] vcs_info git: fix applied-string name
> 
>  - seems pretty obvious
> 
> [PATCH 8/9] vcs_info git: consider patches for rebase
> 
>  - needs git foo currently beyond me to confirm correctness
> 
> [PATCH 9/9] completion git: fix send-email --confirm values
> 
>  - no issues

Thanks for the review,

Marc.