From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33185-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 7209 invoked by alias); 16 Sep 2014 20:21:24 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33185
Received: (qmail 21780 invoked from network); 16 Sep 2014 20:21:23 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:cc:subject:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=kSVnCznf5weyBh2qKDr+GVln0iMVnV6P08W09GOnfJY=;
        b=AOlEkARSI4icPTpEYy5SAYH8DgIxGYkAsALzGZnJT7ihOtvMUkrSYGrjEtjRsgxm6e
         8QC1Ni7K+5RAmckhdF56r4A86xfQoolOd2ZQ9ghFpgtoRL3TzM+zK/EWg+FMds2ejaf2
         ryCcTdoZEQCk1zyqcIR8ixOorU3IzGxXlt85/q0mcdnSOBnZrDcgUUM7mwB+jrCFZ3om
         4ooy5s0MJZHHURUFJPazr1L8CtwXMpsjzC7x6B79I86gejT+5NFMsx3xkDtNucYnCxXI
         g7CD9M4mf4c02WTkcQV5axMc9wMJqjjUXaLUT8wcgND4V+8HAtq/V4LGhkw0lsNRbt52
         GruQ==
X-Received: by 10.180.100.167 with SMTP id ez7mr882939wib.14.1410898880569;
        Tue, 16 Sep 2014 13:21:20 -0700 (PDT)
Date: Tue, 16 Sep 2014 22:19:11 +0200
From: Marc Finet <m.dreadlock@gmail.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 5/9] vcs_info quilt: fix standalone detection
Message-ID: <20140916221911.4ae66547@mlap.lactee>
In-Reply-To: <87ppey7d28.fsf@ft.bewatermyfriend.org>
References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com>
	<1410557443-24178-6-git-send-email-m.dreadlock@gmail.com>
	<87ppey7d28.fsf@ft.bewatermyfriend.org>
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; i586-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 14 Sep 2014 11:42:55 +0200
Frank Terbeck <ft@bewatermyfriend.org> wrote:

> Marc Finet wrote:
> [...]
> > -    if [[ -n "${file}" ]]; then
> > -        oldfile=${vcs_comm[detect_need_file]}
> > -        vcs_comm[detect_need_file]=${file}
> > -    fi
> > +    oldfile=${vcs_comm[detect_need_file]}
> > +    vcs_comm[detect_need_file]=${file}
> >      VCS_INFO_bydir_detect ${dir}
> >      ret=$?
> > -    [[ -n "${file}" ]] && vcs_comm[detect_need_file]=${oldfile}
> > +    vcs_comm[detect_need_file]=${oldfile}
> 
> I don't think this changes anything really, but the removing the
> conditionals makes the code a bit easier to read. So ACK.
I can't remember on which case i fell on this case but
vcs_comm[detect_need_file] was set (and not cleared) by a previous call
hence finally not detecting quilt correctly. While reading at the patch
once more, it might not have interfered with quilt but by an other
backend that set vcs_comm[detect_need_file].

Marc.