From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33186-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10625 invoked by alias); 16 Sep 2014 20:27:51 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33186
Received: (qmail 838 invoked from network); 16 Sep 2014 20:27:49 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW autolearn=ham
	version=3.3.2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:from:to:cc:subject:message-id:in-reply-to:references
         :mime-version:content-type:content-transfer-encoding;
        bh=qHvqRlPRBEIIbFTx32TUCjX4e5znuOGv+us1vGWgsaY=;
        b=X0W10RaGYo05yoIkoQl6aPSQ0conmANgsHiBfKjBsZ5ykc0xFZ+/dk7s+NPqN30uQy
         G9UQFyb0rsnZ/JWl7GxaxbxNLZQR6OQekseon+iqwtP9qLJEeiA3n2CwLyMZs78gXN+k
         Jn1FFDySv2BmBSJMxdLUQRmsPx8n3nwBonOA83A7RWIRec30bJbFgWRE13LmydtSKORs
         GGrRE2uQDv/49OmiHK3rbpLtMr6uSTrqkxObPCfaQ+GHB5ywbB1AeHgwCmk7OZ8vamQb
         pzk7KjwRb7Cd6aXBjhYaYlLzLX+sD/SpqFZtryl8W9LzVteuv1gas7kfWLCGIrmVh63R
         Q3kg==
X-Received: by 10.180.10.230 with SMTP id l6mr829238wib.62.1410899266317;
        Tue, 16 Sep 2014 13:27:46 -0700 (PDT)
Date: Tue, 16 Sep 2014 22:25:37 +0200
From: Marc Finet <m.dreadlock@gmail.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 6/9] vcs_info quilt: fix unapplied detection on
 sub-directory
Message-ID: <20140916222537.0cba87df@mlap.lactee>
In-Reply-To: <87lhpm7ctw.fsf@ft.bewatermyfriend.org>
References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com>
	<1410557443-24178-7-git-send-email-m.dreadlock@gmail.com>
	<87lhpm7ctw.fsf@ft.bewatermyfriend.org>
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; i586-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, 14 Sep 2014 11:47:55 +0200
Frank Terbeck <ft@bewatermyfriend.org> wrote:

> Marc Finet wrote:
> > When being in a subdirectory of a "repo" being handled with quilt,
> > the `quilt unapplied` command returns all the patches because
> > QUILT_PATCHES is an absolute path (which exists and is a dir) and
> > quilt considers that .pc should in current directory.
> > Changing quilt might be overkill and it seems that QUILT_PATCHES
> > should just be a name, not an absolute path.
> [...]
> > -        unapplied=3D( ${(f)"$(QUILT_PATCHES=3D$patches $quiltcommand
> > --quiltrc /dev/null unapplied 2> /dev/null)"} )
> > +        unapplied=3D( ${(f)"$(QUILT_PATCHES=3D$(basename $patches)
> > $quiltcommand --quiltrc /dev/null unapplied 2> /dev/null)"} )
>=20
>=20
> You can't do it like this. With debian-packages for example, quilt
> patches live in =E2=80=98debian/patches=E2=80=99, which the =E2=80=98base=
name=E2=80=99 call would trim
> down to =E2=80=98patches=E2=80=99.
>=20
> If you do need special QUILT_PATCHES treatment, you can set a
> =E2=80=98quit-patches-dir=E2=80=99 style; if the treatment needs to be fa=
ncy, you can
> also set the style to a function, which opens up the door to whatever
> you like.

Hum, I can't remember on which quilt settings the problem occurred (I
should have explained it on the commit message more), but I
have seen the debian/patches on a few places. I need to re-test all the
places i have quilt to be sure of the intended behavior. Please drop
this patch as there is still a problem with debian/patches as with this
patch vcs_info reports twice the number of patches (they appear both in
applied and unapplied, i.e. the problem I tried to fix).

Marc.