From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: zsh seems to be vulnerable to CVE-2014-6271: remote code execution through bash
Date: Fri, 26 Sep 2014 21:08:18 +0100 [thread overview]
Message-ID: <20140926210818.3ac1bf20@pws-pc.ntlworld.com> (raw)
In-Reply-To: <22772.1411740194@thecus.kiddle.eu>
On Fri, 26 Sep 2014 16:03:14 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> For specials of numeric type we appear to be doing math evaluation on
> their values.
> OPTIND='3+4' zsh -c 'echo $OPTIND'
> And if you think you can't do anything with math evaluation:
> x='`date >&2`' OPTIND='pipestatus[1${(e)x}]' zsh -c ':'
>
> Other shells don't even import OPTIND.
This affects OPTIND, TRY_BLOCK_ERROR and SHLVL. It makes no sense
to import the first two at all; they reflect internal status and having
them initialised to something from outside seems wrong.
SHLVL does need to be imported, but doesn't need to be evaluated on
import --- if it's not a straight integer at this point something is
screwy. So this could be checked.
> Would it perhaps make sense to
> revert the sense of PM_DONTIMPORT and have a PM_IMPORT flag so any new
> special is not imported unless whoever implements it actually gives it
> some thought.
Yes, probably.
pws
next prev parent reply other threads:[~2014-09-26 20:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 14:45 İsmail Dönmez
2014-09-24 14:54 ` Frank Terbeck
2014-09-24 14:55 ` İsmail Dönmez
2014-09-24 15:01 ` Peter Stephenson
2014-09-24 15:08 ` Frank Terbeck
2014-09-24 15:13 ` Jérémie Roquet
2014-09-24 14:55 ` Jérémie Roquet
2014-09-24 14:59 ` Chet Ramey
2014-09-25 13:11 ` Peter Stephenson
2014-09-26 14:03 ` Oliver Kiddle
2014-09-26 20:08 ` Peter Stephenson [this message]
2014-09-29 10:04 ` PATCH: safe numeric import Peter Stephenson
2014-09-29 15:24 ` Bart Schaefer
2014-10-01 14:57 ` [Bulk] " Oliver Kiddle
2014-10-02 16:06 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926210818.3ac1bf20@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).