From: Marco Hinz <mh.codebro@gmail.com>
To: zsh-workers@zsh.org
Subject: [patch] Fix VCS_INFO_reposub's whitespace handling
Date: Sun, 28 Sep 2014 19:10:33 +0200 [thread overview]
Message-ID: <20140928171033.GA11234@cheyenne> (raw)
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
Hi,
VCS_INFO_reposub is the function called to process VCS_INFO's %S flag
in 'formats' and 'actionformats'.
Problem:
$ mkdir -p '/tmp/foo bar'
$ cd !$
$ VCS_INFO_reposub
Output:
"tmp/foobar" instead of "tmp/foo bar".
I'm new to zsh internals, but apparently something causes the string
'foo bar' to be read in as 2 arguments. printf only takes 1
argument, and so 'bar' just gets appended.
Could someone point me to the appropriate parameter expansion rule?
Solution:
Double-quote ${$(pwd -P)#$base/}.
Regards,
Marco
[-- Attachment #2: reposub.patch --]
[-- Type: text/x-diff, Size: 349 bytes --]
diff --git a/Functions/VCS_Info/VCS_INFO_reposub b/Functions/VCS_Info/VCS_INFO_reposub
index 1c16f0e..0e6a8b0 100644
--- a/Functions/VCS_Info/VCS_INFO_reposub
+++ b/Functions/VCS_Info/VCS_INFO_reposub
@@ -9,5 +9,5 @@ local base=${1%%/##}
printf '.'
return 1
}
-printf '%s' ${$(pwd -P)#$base/}
+printf '%s' "${$(pwd -P)#$base/}"
return 0
next reply other threads:[~2014-09-28 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 17:10 Marco Hinz [this message]
2014-09-28 17:39 ` Peter Stephenson
2014-09-28 18:52 ` Bart Schaefer
2014-09-29 12:23 ` [PATCH] Fix VCS_INFO_reposub's command expansion Frank Terbeck
2014-09-29 13:26 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928171033.GA11234@cheyenne \
--to=mh.codebro@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).