zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Fix VCS_INFO_reposub's command expansion
Date: Mon, 29 Sep 2014 14:26:28 +0100	[thread overview]
Message-ID: <20140929142628.27e15e54@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <1411993408-31305-1-git-send-email-ft@bewatermyfriend.org>

On Mon, 29 Sep 2014 14:23:28 +0200
Frank Terbeck <ft@bewatermyfriend.org> wrote:
> -[[ $(pwd -P) == ${base}/* ]] || {
> +tmp="$(pwd -P)"
> +[[ $tmp == ${base}/* ]] || {

There's no problem with this change, but actually you get away with it
anyway here since the [[ ... ]] context knows it should expand as a
single word.

[[ $(print eurgh yuk) == "eurgh yuk" ]] && print OK

pws


      reply	other threads:[~2014-09-29 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28 17:10 [patch] Fix VCS_INFO_reposub's whitespace handling Marco Hinz
2014-09-28 17:39 ` Peter Stephenson
2014-09-28 18:52 ` Bart Schaefer
2014-09-29 12:23 ` [PATCH] Fix VCS_INFO_reposub's command expansion Frank Terbeck
2014-09-29 13:26   ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140929142628.27e15e54@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).