From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5675 invoked by alias); 30 Sep 2014 08:53:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33293 Received: (qmail 16718 invoked from network); 30 Sep 2014 08:53:27 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f5-b7f776d000003e54-19-542a6f84f8bc Date: Tue, 30 Sep 2014 09:53:23 +0100 From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: Misc. compile warnings Message-id: <20140930095323.21c81922@pwslap01u.europe.root.pri> In-reply-to: References: Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphluLIzCtJLcpLzFFi42I5/e/4Nd2WfK0Qg/lbbCwONj9kcmD0WHXw A1MAYxSXTUpqTmZZapG+XQJXxrKJD9kKDvNXnD72namB8Rl3FyMnh4SAiUTv3aeMELaYxIV7 69m6GLk4hASWMkosWLOdBSQhJLCcSeL0Ag4Qm0VAVWLFnHnsIDabgKHE1E2zwZpFBMQlzq49 D1YvLKAscfTFFWYQm1fAXuJu1y5WEJtTwFli6qJmJoiZThKLlp0Hm8MvoC9x9e8nJogj7CVm XjnDCNErKPFj8j2wmcwCWhKbtzWxQtjyEpvXvGWewCgwC0nZLCRls5CULWBkXsUomlqaXFCc lJ5rpFecmFtcmpeul5yfu4kREoJfdzAuPWZ1iFGAg1GJhzdBUStEiDWxrLgy9xCjBAezkggv TxZQiDclsbIqtSg/vqg0J7X4ECMTB6dUA+Oet12mWiftGA78Xaa3UC35QM/1GUcDKsT0Tv14 nh8g/mPraWe351xW90p3Z+3Y3p2b6/hvH8+/b2udV+5LPvIg4oOzy79bF7/+Pj33SZX1Ye+l Z6xrXkTEfby4wsH83UwTaccVk76yX6s595W7cW1WTdWeo+LWqdMUl8+SXhtkIbhbLPUES8Nl JZbijERDLeai4kQAJy6xYR8CAAA= On Mon, 29 Sep 2014 14:01:17 -0700 (PDT) Bart Schaefer wrote: > Just upgraded Mavericks and am seeing some compile warnings I don't recall > having encountered before: > > compctl.c:3419:11: warning: expression which evaluates to zero treated as a null > pointer constant of type 'char *' [-Wnon-literal-null-conversion] > *npp = '\0'; > ^~~~ > > zle_refresh.c:432:13: warning: expression which evaluates to zero treated as a > null pointer constant of type 'char *' [-Wnon-literal-null-conversion] > *arrp = '\0'; > ^~~~ The point is *npp and *arrp are char *, not char, so should be NULL, not a character zero. > zle_refresh.c:261:30: warning: unused variable 'zr_ht' [-Wunused-const-variable] > static const REFRESH_ELEMENT zr_ht = { ZWC('\t'), 0 }; Yes, it's not used. pws diff --git a/Src/Zle/compctl.c b/Src/Zle/compctl.c index 52b9e9c..0b7a324 100644 --- a/Src/Zle/compctl.c +++ b/Src/Zle/compctl.c @@ -3416,7 +3416,7 @@ makecomplistflags(Compctl cc, char *s, int incmd, int compadd) *npp++ = tp; pp++; } - *npp = '\0'; + *npp = NULL; } } if (!dirs) { diff --git a/Src/Zle/zle_refresh.c b/Src/Zle/zle_refresh.c index 80be27f..684ac13 100644 --- a/Src/Zle/zle_refresh.c +++ b/Src/Zle/zle_refresh.c @@ -258,7 +258,6 @@ static const REFRESH_ELEMENT zr_cr = { ZWC('\r'), 0 }; static const REFRESH_ELEMENT zr_dt = { ZWC('.'), 0 }; static const REFRESH_ELEMENT zr_nl = { ZWC('\n'), 0 }; static const REFRESH_ELEMENT zr_sp = { ZWC(' '), 0 }; -static const REFRESH_ELEMENT zr_ht = { ZWC('\t'), 0 }; static const REFRESH_ELEMENT zr_zr = { ZWC('\0'), 0 }; /* @@ -429,7 +428,7 @@ get_region_highlight(UNUSED(Param pm)) digbuf1, digbuf2); (void)output_highlight(rhp->atr, *arrp + strlen(*arrp)); } - *arrp = '\0'; + *arrp = NULL; return retarr; }