From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25852 invoked by alias); 1 Oct 2014 14:15:18 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33304 Received: (qmail 12629 invoked from network); 1 Oct 2014 14:15:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f5-b7f776d000003e54-07-542c0c662a10 To: undisclosed-recipients: ; Date: Wed, 01 Oct 2014 15:15:01 +0100 From: Peter Stephenson Cc: zsh-workers@zsh.org Subject: Re: _expand_alias does not expand aliases that contain an "!" Message-id: <20141001151501.2eac05ef@pwslap01u.europe.root.pri> In-reply-to: <20141001150641.02e52281@pwslap01u.europe.root.pri> References: <140830133206.ZM13172@torch.brasslantern.com> <140831135017.ZM739@torch.brasslantern.com> <140914113029.ZM31296@torch.brasslantern.com> <140914135552.ZM31608@torch.brasslantern.com> <20141001150324.1cdad6c9@pwslap01u.europe.root.pri> <20141001150641.02e52281@pwslap01u.europe.root.pri> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOLMWRmVeSWpSXmKPExsVy+t/xy7ppPDohBnPPiVscbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujA8vvzEWbOWsmN1u0cB4lL2LkZNDQsBEYv+ts1C2mMSFe+vZ uhi5OIQEljJKzDvcwAqSEBGQkZg7+zErRGI5k8T0o5+Zuhg5OFgEVCVaPlWD1LAJGEpM3TSb ESTMLCAuMXtKIEhYWMBNYnP7N7D5vAL2Ej33njCB2JwCDhKX5nxihxh5mFni14XXYAl+AX2J q38/MUEcZC8x88oZRohmQYkfk++xgNjMAloSm7c1sULY8hKb17xlnsAoOAtJ2SwkZbOQlC1g ZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERKYX3cwLj1mdYhRgINRiYdXI107RIg1say4 MvcQowQHs5IILzunTogQb0piZVVqUX58UWlOavEhRiYOTqkGRkXDzi95Se8W+nzv3T7tybfF OgvKg6ac+7vA53OTXZbyrnbB9RfOfvi4/+6TKKnMtbM5PdeorH6eZapzcBZz/6PuEk65z+4Z s16mzH5+Wllo6Z7U6vMnuaRnKNZFHHZeaqxUs+tVZQLfrJyohJO3XuTKf48S+GuXX67odzVa +3rV0YWVbAbzLJVYijMSDbWYi4oTAU8Wuc4qAgAA On Wed, 01 Oct 2014 15:06:41 +0100 Peter Stephenson wrote: > On Wed, 1 Oct 2014 15:03:24 +0100 > Peter Stephenson wrote: > > On possible fix would be to add a separate variable to remember the > > original ISPECIAL bit for bangchar (which would be transferable if > > bangchar became a different character) and restore it at this point if > > this isn't the original setting up of typtab --- which is where the last > > two tests really make sense. So only the first two tests would remain > > here in all cases. That may seem a bit baroque given no other character > > needs this, but it makes the code relatively insensitive to context. > > Immediately after hitting "Send"(*), it occurred to me this just needs > to be another bit in the typtab element, ISPECIAL_ORIGINALLY, though we > still need to tell the code at this point whether or not this is the > original case (easy enough). Gag. Sorry, no, that doesn't work if we change bangchar. We'd have to check if ISPECIAL_ORIGINALLY was set for the current bangchar before changing and then pass that information back in, which far outweighs the convenience. pws