From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.6 hanged in freejob from TRAPCHLD
Date: Wed, 01 Oct 2014 16:40:02 +0100 [thread overview]
Message-ID: <20141001164002.0f9b1e01@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <28552.1412177133@thecus.kiddle.eu>
On Wed, 01 Oct 2014 17:25:33 +0200
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Bart wrote:
> > This plus the possibility of interrupting the copy from the saved state
> > back to the globals is the need for queue_signals() inside lexrestore().
>
> Eww. Wouldn't it perhaps be easier and better in the long run to replace
> this whole save/restore/globals concept with non-global structs and make
> all the lexer functions take a pointer to the relevant instance of the
> struct.
Better --- highly likely.
Easier --- only after you've persuaded someone else to do the work.
You'll soon find the paths you need to pass the structures through
proliferate somewhat hair-raisingly. That may lead to useful
simplifications, though, so this isn't an argument against doing it.
pws
next prev parent reply other threads:[~2014-10-01 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 17:21 Vincent Lefevre
2014-09-30 23:18 ` Bart Schaefer
2014-10-01 0:53 ` PATCH signal-safe lexrestore() [Re: zsh 5.0.6 hanged in freejob from TRAPCHLD] Bart Schaefer
2014-10-01 9:00 ` zsh 5.0.6 hanged in freejob from TRAPCHLD Peter Stephenson
2014-10-01 14:53 ` Bart Schaefer
2014-10-01 15:25 ` Oliver Kiddle
2014-10-01 15:40 ` Peter Stephenson [this message]
2014-10-01 16:04 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001164002.0f9b1e01@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).