From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24712 invoked by alias); 1 Oct 2014 15:40:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33308 Received: (qmail 6827 invoked from network); 1 Oct 2014 15:40:06 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f5-b7f776d000003e54-94-542c2053472a Date: Wed, 01 Oct 2014 16:40:02 +0100 From: Peter Stephenson To: Zsh hackers list Subject: Re: zsh 5.0.6 hanged in freejob from TRAPCHLD Message-id: <20141001164002.0f9b1e01@pwslap01u.europe.root.pri> In-reply-to: <28552.1412177133@thecus.kiddle.eu> References: <20140930172125.GA2703@xvii.vinc17.org> <20141001100033.0e10a30c@pwslap01u.europe.root.pri> <141001075325.ZM5718@torch.brasslantern.com> <28552.1412177133@thecus.kiddle.eu> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4Fd1gBZ0Qg8fT9C0ONj9kcmD0WHXw A1MAYxSXTUpqTmZZapG+XQJXxqG5V5gL5rNVtP99xNjA2MraxcjJISFgIjHz+QtmCFtM4sK9 9WxdjFwcQgJLGSUOPzvJAuEsZ5I4cmcBWAeLgKrEzcmL2EBsNgFDiambZjOC2CICWhI7Tp5k ArGFBcwkvq84wgJi8wrYSxydPpUdxOYUMJCYvHkBI8TQViaJDfN6wIr4BfQlrv79xARxhr3E zCtnGCGaBSV+TL4HVsMMtGDztiZWCFteYvOat8wTGAVmISmbhaRsFpKyBYzMqxhFU0uTC4qT 0nON9IoTc4tL89L1kvNzNzFCwvDrDsalx6wOMQpwMCrx8Gqka4cIsSaWFVfmHmKU4GBWEuHV lNMJEeJNSaysSi3Kjy8qzUktPsTIxMEp1cB4+verPkXf/pTpgk8l5D6FRS1tc153+kdoz4zb nfER70xuJU/9VPXVUDqYqePRao1fFh8nzp/DdeK5xNaHJpvPJ81bW3i6g/HhXx278lvLDXLC WFhdTUSipW/8ef5Cwzu6ZM2qtdoVPEdfpX6q6pnYxNEflVvZsjXSWslxnpHCq0tB0RsNHqoo sRRnJBpqMRcVJwIAK8ZHWyECAAA= On Wed, 01 Oct 2014 17:25:33 +0200 Oliver Kiddle wrote: > Bart wrote: > > This plus the possibility of interrupting the copy from the saved state > > back to the globals is the need for queue_signals() inside lexrestore(). > > Eww. Wouldn't it perhaps be easier and better in the long run to replace > this whole save/restore/globals concept with non-global structs and make > all the lexer functions take a pointer to the relevant instance of the > struct. Better --- highly likely. Easier --- only after you've persuaded someone else to do the work. You'll soon find the paths you need to pass the structures through proliferate somewhat hair-raisingly. That may lead to useful simplifications, though, so this isn't an argument against doing it. pws