From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9424 invoked by alias); 3 Oct 2014 15:42:37 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33347 Received: (qmail 15696 invoked from network); 3 Oct 2014 15:42:35 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f5-b7f776d000003e54-4a-542ec3e208ca Date: Fri, 03 Oct 2014 16:42:25 +0100 From: Peter Stephenson To: zsh workers Subject: Re: More crash Re: More incmdpos stuff Re: Crash Re: Trial for 5.0.7 Message-id: <20141003164225.56d8c5a1@pwslap01u.europe.root.pri> In-reply-to: <141003083327.ZM15145@torch.brasslantern.com> References: <20141003132702.044f9475@pwslap01u.europe.root.pri> <141003075022.ZM14943@torch.brasslantern.com> <20141003161518.01cbc081@pwslap01u.europe.root.pri> <141003083327.ZM15145@torch.brasslantern.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphluLIzCtJLcpLzFFi42I5/e/4Nd1Hh/VCDG51mVkcbH7I5MDoserg B6YAxigum5TUnMyy1CJ9uwSujNsbutgLNrNVPJ1yi62B8QFLFyMnh4SAicTGCd1sELaYxIV7 68FsIYGljBJ3p3J1MXIB2cuZJHZP3cAIkmARUJXYsPcrWBGbgKHE1E2zweIiQPHm7//AhgoL +Eqc3veJuYuRg4NXwF7i+b8gkDCngJVE8/Q3jBAz5zFJfN95ix0kwS+gL3H17ycmiCPsJWZe OQM2k1dAUOLH5HtgM5kFtCQ2b2tihbDlJTavecs8gVFgFpKyWUjKZiEpW8DIvIpRNLU0uaA4 KT3XSK84Mbe4NC9dLzk/dxMjJAS/7mBceszqEKMAB6MSD++HG7ohQqyJZcWVuYcYJTiYlUR4 F6zUCxHiTUmsrEotyo8vKs1JLT7EyMTBKdXAaJCntCbk8Rwz1qXnmq8KOwbUHmm77bt3gnTu EaHUw8/W7Yiv0j8jl/a67t3qLIMIL+ZFB862Rd4t2nzE+cyriPyb0Xtjp8xhUN60eVkum8xl d/9C7aUnXxoYVmxu33w7OU195eKIE9M7xS1cr07dL8CaOrvEnYeDe57IvpUPtbLa9roJb0tZ pcRSnJFoqMVcVJwIAIo20OIfAgAA On Fri, 03 Oct 2014 08:33:27 -0700 Bart Schaefer wrote: > On Oct 3, 4:15pm, Peter Stephenson wrote: > } Subject: Re: More crash Re: More incmdpos stuff Re: Crash Re: Trial for 5. > } > } The explanation is I screwed up. *complex should never be set to 0 > } except where the variable pointed to is created --- it should only be > } conditionally set to 1. (For zsh-shaped values of "never".) > > Does that mean we need this, too? > > > --- a/Src/parse.c > +++ b/Src/parse.c > @@ -1517,7 +1517,8 @@ par_funcdef(int *complex) > num++; > zshlex(); > } > - *cmplx = (num > 0); > + if (num > 0) > + *cmplx = 1; > ecbuf[parg] = ecused - parg; /*?*/ > ecbuf[parg+1] = num; > } Yes, that's yet another variant syntax SNAFU. Thanks. pws