From: Marc Finet <m.dreadlock@gmail.com>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory
Date: Thu, 9 Oct 2014 00:36:19 +0200 [thread overview]
Message-ID: <20141009003619.00001016@mlap.lactee> (raw)
In-Reply-To: <87lhpm7ctw.fsf@ft.bewatermyfriend.org>
On Sun, Sep 14, 2014 at 11:47:55AM +0200, Frank Terbeck wrote:
> Marc Finet wrote:
> > When being in a subdirectory of a "repo" being handled with quilt,
> > the `quilt unapplied` command returns all the patches because
> > QUILT_PATCHES is an absolute path (which exists and is a dir) and
> > quilt considers that .pc should in current directory.
> > Changing quilt might be overkill and it seems that QUILT_PATCHES
> > should just be a name, not an absolute path.
> [...]
> > - unapplied=( ${(f)"$(QUILT_PATCHES=$patches $quiltcommand --quiltrc /dev/null unapplied 2> /dev/null)"} )
> > + unapplied=( ${(f)"$(QUILT_PATCHES=$(basename $patches) $quiltcommand --quiltrc /dev/null unapplied 2> /dev/null)"} )
>
>
> You can't do it like this. With debian-packages for example, quilt
> patches live in ‘debian/patches’, which the ‘basename’ call would trim
> down to ‘patches’.
>
> If you do need special QUILT_PATCHES treatment, you can set a
> ‘quit-patches-dir’ style; if the treatment needs to be fancy, you can
> also set the style to a function, which opens up the door to whatever
> you like.
Hum, in fact this commit was intented to 'fix' such the debian/ behavior
but miserably failed. I tested different settings and here are my results;
for debian patches, the working tree is as follows:
work/
├── debian/
│ ├── patches/
│ │ ├── series (list of patches to apply)
│ │ ├── patch1.diff (one particular patch)
│ │ ├── patch2.diff
│ │ └── ...
│ └── ...
├── .pc/
│ ├── .quilt_patches (content of QUILT_PATCHES)
│ ├── .quilt_series (content of QUILT_SERIES)
│ ├── patch1.diff/ (copy of patched files)
│ │ └── ...
│ ├── patch2.diff/
│ │ └── ...
│ └── ...
└── ...
But:
- 1) without setting QUILT_PATCHES nor quilt-patch-dir:
- quilt is not detected in work/
- quilt is detected in work/anything/ but reports all patches
as both applied and unapplied (%a/%p gives x/2x)
- `quilt` does not work if no .pc/ exists
- 2) with QUILT_PATCHES set to "debian":
- quilt is detected everywhere and reports correct patches
numbers
- but `quilt` stops to work (e.g. `quilt series` shows only
latest patch, `quilt pop` fails)
- 3) with QUILT_PATCHES set to "debian/patches":
- quilt is detected in work/
- quilt is detected in work/anything/ but reports all patches
as both applied and unapplied (%a/%p gives x/2x)
- `quilt` works when no .pc/ exists
- 4) with quilt-patch-dir set to "debian"
- quilt is correctly detected everywhere
- but unapplied patches are not detected (due to missing /patches when
setting QUILT_PATCHES on quilt unapplied invocation)
- but `quilt` does not work if no .pc/ exists
- 5) with quilt-patch-dir set to "debian/patches":
- quilt is detected in work/
- quilt is detect in work/anything/ but reports all patches
as both applied and unapplied (%a/%p gives x/2x)
So I do not understand the role of quilt-patch-dir as for me it takes
the role of QUILT_PATCHES except the missing '/patches'. Moreover changing
to sub-directory in cases 1, 3 and 5 makes applied patch detection failing
because:
- applied is patch1.diff patch2.diff ...
- unapplied is /path/to/work/debian/patches/patch1.diff ...
For me $patches should have the QUILT_PATCHES semantic, i.e. include the
/patches at end (as said in man page). If you agree with this analysis, i
might find a patch to make cases 3 and 5 working (even if it breaks the
quite-working case 4). And re-reading the man page gives me a hint for the
quilt-patch-dir usage: configure QUILT_PATCHES (with hook) per repository
with zstyle ?
Marc
next prev parent reply other threads:[~2014-10-08 22:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 21:30 Misc patches for git completion and vcs_info Marc Finet
2014-09-12 21:30 ` [PATCH 1/9] vcs_info examples: fix typo Marc Finet
2014-09-14 9:33 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 2/9] completion git: support aliases when \n exist Marc Finet
2014-09-12 21:30 ` [PATCH 3/9] vcs_info git: detect revert or cherry-pick with multiple commits Marc Finet
2014-09-14 9:36 ` Frank Terbeck
2014-09-15 6:22 ` Phil Pennock
2014-09-12 21:30 ` [PATCH 4/9] vcs_info git: set rrn before using it Marc Finet
2014-09-14 9:33 ` Frank Terbeck
2014-09-16 20:07 ` Marc Finet
2014-09-16 20:41 ` Frank Terbeck
2014-09-16 20:57 ` Marc Finet
2014-09-16 21:23 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 5/9] vcs_info quilt: fix standalone detection Marc Finet
2014-09-14 9:42 ` Frank Terbeck
2014-09-16 20:19 ` Marc Finet
2014-09-12 21:30 ` [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory Marc Finet
2014-09-14 9:47 ` Frank Terbeck
2014-09-16 20:25 ` Marc Finet
2014-10-08 22:36 ` Marc Finet [this message]
2014-10-09 16:03 ` Frank Terbeck
2014-10-16 4:59 ` Marc Finet
2014-10-16 8:17 ` Frank Terbeck
2014-11-08 10:46 ` Marc Finet
2014-11-11 10:07 ` Marc Finet
2015-01-02 11:03 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 7/9] vcs_info git: fix applied-string name Marc Finet
2014-09-14 9:49 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 8/9] vcs_info git: consider patches for rebase Marc Finet
2014-09-14 10:08 ` Frank Terbeck
2014-09-14 10:13 ` Frank Terbeck
2014-09-16 20:07 ` Marc Finet
2014-09-12 21:30 ` [PATCH 9/9] completion git: fix send-email --confirm values Marc Finet
2014-09-14 10:11 ` Frank Terbeck
2014-09-12 23:50 ` Misc patches for git completion and vcs_info Bart Schaefer
2014-09-13 7:35 ` Marc Finet
2014-09-13 12:23 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009003619.00001016@mlap.lactee \
--to=m.dreadlock@gmail.com \
--cc=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).