zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: bug with completion in quotes
Date: Sun, 12 Oct 2014 20:44:29 +0100	[thread overview]
Message-ID: <20141012204429.568ff0c5@pws-pc.ntlworld.com> (raw)
In-Reply-To: <141012112943.ZM23943@torch.brasslantern.com>

On Sun, 12 Oct 2014 11:29:43 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:

> On Oct 12,  6:51pm, Peter Stephenson wrote:
> }
> } Although that function is a permanent black stain on my soul, before I
> } send others on wild goose chases I don't think it can be the culprit
> } here since I think it's *only* used for recursive quotes.  I'm now
> } wondering about get_comp_string() from line 1676 in zle_tricky.c,
> } including the grumpy comment I would guess is from me, since they usually
> } are, around line 1686.  However, I haven't gone into the nitty gritty.
> 
> It's definitely get_comp_string(), probably via getkeystring() in utils.c
> 
> See my earlier email.

I think this is zsh-workers/23809, commit
e0a3e74b15fd39b21ef1770e67e2f005321b5fb9, going off at the wrong time.
It was supposed to apply to expanding complete $'...' expressions, but
in this case it's being applied to an uncompleted completion.

It looks like the intended purpose is basically OK since completing
after a $'...' works OK, at least in simple cases.  So it may be we
simply need to skip the code added by that change --- simply setting
skipchars to 2 instead looks like it's probably the right thing to do
--- if we're in the middle of it.

I think this is roughly what the "i + (pe - p) < zlemetacs" test is
trying to do at line 1721.  Evidently it's not working.  Presumably one
of the many ad hoc offsets hasn't been taken account of.

pws


  reply	other threads:[~2014-10-12 19:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11 22:37 Oliver Kiddle
2014-10-12  4:41 ` Bart Schaefer
2014-10-12 17:35 ` Peter Stephenson
2014-10-12 17:51   ` Peter Stephenson
2014-10-12 18:29     ` Bart Schaefer
2014-10-12 19:44       ` Peter Stephenson [this message]
2014-10-12 20:15         ` Peter Stephenson
2014-10-12 20:36           ` Bart Schaefer
2014-10-20 17:22 ` Peter Stephenson
2014-10-22 14:05   ` Oliver Kiddle
2014-10-22 14:28     ` Peter Stephenson
2014-10-24  8:51       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141012204429.568ff0c5@pws-pc.ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).