From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18542 invoked by alias); 12 Oct 2014 20:16:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33451 Received: (qmail 14269 invoked from network); 12 Oct 2014 20:15:58 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Originating-IP: [80.3.229.105] X-Spam: 0 X-Authority: v=2.1 cv=RcseCjdv c=1 sm=1 tr=0 a=uz1KDxDNIq33yePw376BBA==:117 a=uz1KDxDNIq33yePw376BBA==:17 a=NLZqzBF-AAAA:8 a=uObrxnre4hsA:10 a=kj9zAlcOel0A:10 a=q2GGsy2AAAAA:8 a=NOON6nbB2NCcEcBOO-YA:9 a=CjuIK1q_8ugA:10 a=_dQi-Dcv4p4A:10 a=I6wTmPyJxzYA:10 Date: Sun, 12 Oct 2014 21:15:55 +0100 From: Peter Stephenson To: Zsh workers Subject: Re: bug with completion in quotes Message-ID: <20141012211555.7637b7ec@pws-pc.ntlworld.com> In-Reply-To: <20141012204429.568ff0c5@pws-pc.ntlworld.com> References: <13524.1413067029@thecus.kiddle.eu> <20141012183547.707f1818@pws-pc.ntlworld.com> <20141012185125.62c73587@pws-pc.ntlworld.com> <141012112943.ZM23943@torch.brasslantern.com> <20141012204429.568ff0c5@pws-pc.ntlworld.com> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 12 Oct 2014 20:44:29 +0100 Peter Stephenson wrote: > On Sun, 12 Oct 2014 11:29:43 -0700 > Bart Schaefer wrote: > > > On Oct 12, 6:51pm, Peter Stephenson wrote: > > } > > } Although that function is a permanent black stain on my soul, before I > > } send others on wild goose chases I don't think it can be the culprit > > } here since I think it's *only* used for recursive quotes. I'm now > > } wondering about get_comp_string() from line 1676 in zle_tricky.c, > > } including the grumpy comment I would guess is from me, since they usually > > } are, around line 1686. However, I haven't gone into the nitty gritty. > > > > It's definitely get_comp_string(), probably via getkeystring() in utils.c > > > > See my earlier email. > > I think this is zsh-workers/23809, commit > e0a3e74b15fd39b21ef1770e67e2f005321b5fb9, going off at the wrong time. > It was supposed to apply to expanding complete $'...' expressions, but > in this case it's being applied to an uncompleted completion. > > It looks like the intended purpose is basically OK since completing > after a $'...' works OK, at least in simple cases. So it may be we > simply need to skip the code added by that change --- simply setting > skipchars to 2 instead looks like it's probably the right thing to do > --- if we're in the middle of it. Sigh. Nope. I think it *is* doing the skipchars == 2 branch but that's not the right thing to do for some reason. I don't know what is. pws