Re: Drat, Test/A05 still hanging sometimes

[Axel Beckert <abe@deuxchevaux.org>]

Hi Bart,

On Mon, Oct 13, 2014 at 10:18:03AM -0700, Bart Schaefer wrote:
> Give the following a try?  With the "sleep" in there, I am unable to
> make the A05 test hang.  Without it, I get one hang in each 20 repeats
> of the test, pretty reliably.

Thanks. I've made an upload to Debian Experimental last night with a
bunch of cherry-picked post-5.0.7 patches plus this one.

> Although why putting the sleep at that particular place has the right
> side-effect, I do not know.
> 
> diff --git a/Test/A05execution.ztst b/Test/A05execution.ztst
> index ca97f4f..0b40a73 100644
> --- a/Test/A05execution.ztst
> +++ b/Test/A05execution.ztst
> @@ -208,6 +208,7 @@ F:This similar test was triggering a reproducible failure with pipestatus.
>    print -u $ZTST_fd 'This test takes 5 seconds to fail...'
>    { printf "%d\n" {1..20000} } | ( read -e )
>    hang(){ printf "%d\n" {2..20000} | cat }; hang | ( read -e )
> +  sleep 1 ;: avoid coproc exit race condition
>    print -p done
>    read -et 6 -p
>  0:Bug regression: piping a shell construct to an external process may hang

One build failure so far (four slower/busier architectures still
outstanding), but it happened on the architecture where it happened
the most often so far (kfreebsd-amd64). It was inside A05, but not at
the above location but at the test starting at line 179 (or not
properly synced output):

https://buildd.debian.org/status/fetch.php?pkg=zsh&arch=kfreebsd-amd64&ver=5.0.7-2&stamp=1413276687

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)