From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33503-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 7135 invoked by alias); 22 Oct 2014 13:28:33 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33503
Received: (qmail 26835 invoked from network); 22 Oct 2014 13:28:31 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham
	version=3.3.2
X-Greylist: Passed host: 79.255.37.155
X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-14.arcor-online.net 05C339BE5D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arcor.de; s=mail-in;
	t=1413982502; bh=bToWVWJ1L5zeTWpc2wdO93RWcMrP5sZZaGPB+FTIsis=;
	h=Date:From:To:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type:Content-Transfer-Encoding;
	b=l6JRu6aMLsB12k6JedlbajIZ6CWsAHPzNns7MBKEQSqlLvGEhaiHWhY5ymwWwgSV7
	 FwQop1yYW9lC6+JF98jvJDNlX/YzzvazGr7speRIvLky3iOOA0xJKhM/WNwxrLPLu/
	 9kN22Lv4MPqhiOKOsyUAK1bIJ5hUc7iT6z4t+coY=
Date: Wed, 22 Oct 2014 14:54:53 +0200
From: Manfred Lotz <manfred.lotz@arcor.de>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] vcs_info: Use =?UTF-8?B?4oCYY29tbWFuZOKAmQ==?= prefix
 to call version control programs
Message-ID: <20141022145453.5f25f831@hogwart.bsdlocal.net>
In-Reply-To: <87h9ywb9by.fsf@ft.bewatermyfriend.org>
References: <141021232256.ZM14769@torch.brasslantern.com>
	<1413970104-5500-1-git-send-email-ft@bewatermyfriend.org>
	<20141022105356.GB1692@tarsus.local2>
	<87h9ywb9by.fsf@ft.bewatermyfriend.org>
X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Thanks all for answering.

On Wed, 22 Oct 2014 14:03:13 +0200
Frank Terbeck <ft@bewatermyfriend.org> wrote:

> Hey Daniel,
> 
> Daniel Shahaf wrote:
> > Frank Terbeck wrote on Wed, Oct 22, 2014 at 11:28:24 +0200:
> [...]
> >>     I think this is reasonable. I hope, people don't count on
> >>     wrapper functions to work to achieve some sort of sinister
> >>     hack. :)
> >> 
> >
> > I hate to say this after you already wrote the patch, but:
> 
> No worries. Changing those lines took like five minutes. :)
> 
> > There are legitimate use-cases for wrapper functions, and your patch
> > would break them.  (For example, someone might use a wrapper
> > function to dispatch to a different svn binary depending on the
> > working copy they are in.)
> 
> I was afraid someone might say that. :)
> 

I agree there are use-cases for a wrapper function. :-)

Although in my case I could fix it easily in my function svn() because
I always issue a debug message to stdout (in this case stderr would
be better I have to admit) which makes normal parsing of the svn command
fail if function svn gets called instead of command svn. After removing
it all is fine now.

Nevertheless, I think a wrapper function isn't illegal and shouldn't
fail. 


-- 
Manfred