From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Macro redefined warnings in zftp.c
Date: Fri, 31 Oct 2014 10:05:12 +0000 [thread overview]
Message-ID: <20141031100512.0e036854@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <alpine.LRH.2.00.1410301622160.26348@toltec.zanshin.com>
On Thu, 30 Oct 2014 16:23:58 -0700 (PDT)
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Just noticed these (harmless but lengthy) compiler warnings when building
> on MacOS:
>
>
> In file included from zftp.c:54:
> ./zftp.mdh:5:12: warning: 'boot_' macro redefined
> # define boot_ boot_zshQszftp
> ^
> ./tcp.mdh:5:12: note: previous definition is here
> # define boot_ boot_zshQsnetQstcp
> ^
I don't think we need the internal module definitions for the tcp module
in the zftp module, just the public interface.
diff --git a/Src/Modules/zftp.c b/Src/Modules/zftp.c
index d16e2f6..09d4bd7 100644
--- a/Src/Modules/zftp.c
+++ b/Src/Modules/zftp.c
@@ -50,7 +50,6 @@ struct zftp_session;
typedef struct zftp_session *Zftp_session;
#include "tcp.h"
-#include "tcp.mdh"
#include "zftp.mdh"
#include "zftp.pro"
pws
prev parent reply other threads:[~2014-10-31 10:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 23:23 Bart Schaefer
2014-10-31 10:05 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031100512.0e036854@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).