zsh-workers
 help / color / mirror / code / Atom feed
* Macro redefined warnings in zftp.c
@ 2014-10-30 23:23 Bart Schaefer
  2014-10-31 10:05 ` Peter Stephenson
  0 siblings, 1 reply; 2+ messages in thread
From: Bart Schaefer @ 2014-10-30 23:23 UTC (permalink / raw)
  To: zsh-workers

Just noticed these (harmless but lengthy) compiler warnings when building
on MacOS:


In file included from zftp.c:54:
./zftp.mdh:5:12: warning: 'boot_' macro redefined
#   define boot_ boot_zshQszftp
           ^
./tcp.mdh:5:12: note: previous definition is here
#   define boot_ boot_zshQsnetQstcp
           ^
In file included from zftp.c:54:
./zftp.mdh:6:12: warning: 'cleanup_' macro redefined
#   define cleanup_ cleanup_zshQszftp
           ^
./tcp.mdh:6:12: note: previous definition is here
#   define cleanup_ cleanup_zshQsnetQstcp
           ^
In file included from zftp.c:54:
./zftp.mdh:7:12: warning: 'features_' macro redefined
#   define features_ features_zshQszftp
           ^
./tcp.mdh:7:12: note: previous definition is here
#   define features_ features_zshQsnetQstcp
           ^
In file included from zftp.c:54:
./zftp.mdh:8:12: warning: 'enables_' macro redefined
#   define enables_ enables_zshQszftp
           ^
./tcp.mdh:8:12: note: previous definition is here
#   define enables_ enables_zshQsnetQstcp
           ^
In file included from zftp.c:54:
./zftp.mdh:9:12: warning: 'setup_' macro redefined
#   define setup_ setup_zshQszftp
           ^
./tcp.mdh:9:12: note: previous definition is here
#   define setup_ setup_zshQsnetQstcp
           ^
In file included from zftp.c:54:
./zftp.mdh:10:12: warning: 'finish_' macro redefined
#   define finish_ finish_zshQszftp
           ^
./tcp.mdh:10:12: note: previous definition is here
#   define finish_ finish_zshQsnetQstcp
           ^
6 warnings generated.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Macro redefined warnings in zftp.c
  2014-10-30 23:23 Macro redefined warnings in zftp.c Bart Schaefer
@ 2014-10-31 10:05 ` Peter Stephenson
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Stephenson @ 2014-10-31 10:05 UTC (permalink / raw)
  To: zsh-workers

On Thu, 30 Oct 2014 16:23:58 -0700 (PDT)
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Just noticed these (harmless but lengthy) compiler warnings when building
> on MacOS:
> 
> 
> In file included from zftp.c:54:
> ./zftp.mdh:5:12: warning: 'boot_' macro redefined
> #   define boot_ boot_zshQszftp
>            ^
> ./tcp.mdh:5:12: note: previous definition is here
> #   define boot_ boot_zshQsnetQstcp
>            ^

I don't think we need the internal module definitions for the tcp module
in the zftp module, just the public interface.

diff --git a/Src/Modules/zftp.c b/Src/Modules/zftp.c
index d16e2f6..09d4bd7 100644
--- a/Src/Modules/zftp.c
+++ b/Src/Modules/zftp.c
@@ -50,7 +50,6 @@ struct zftp_session;
 typedef struct zftp_session *Zftp_session;
 
 #include "tcp.h"
-#include "tcp.mdh"
 #include "zftp.mdh"
 #include "zftp.pro"
 
pws


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-31 10:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-30 23:23 Macro redefined warnings in zftp.c Bart Schaefer
2014-10-31 10:05 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).