From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: keep region active when widget fails
Date: Fri, 07 Nov 2014 09:36:39 +0000 [thread overview]
Message-ID: <20141107093639.4fe68607@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <8414.1415317703@thecus.kiddle.eu>
On Fri, 07 Nov 2014 00:48:23 +0100
Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Does anyone know why we set region_active to false in handlefeep()? I
> would guess that there are perhaps cases where we want this but things
> like cursor left when you're already in the first position shouldn't
> unset region_active. Any objections to the following patch? We can
> always add the assignment to individual widgets if we find cases where
> it is desirable.
That sounds OK --- I can't see any big problem.
pws
prev parent reply other threads:[~2014-11-07 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 23:48 Oliver Kiddle
2014-11-07 0:37 ` Bart Schaefer
2014-11-07 9:04 ` PATCH: Add an option to disable deactivating region hilighting whenever you edit something Mikael Magnusson
2014-11-07 10:15 ` Oliver Kiddle
2014-11-07 10:42 ` Mikael Magnusson
2014-11-07 9:36 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107093639.4fe68607@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).