From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27098 invoked by alias); 7 Nov 2014 09:36:54 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33627 Received: (qmail 17842 invoked from network); 7 Nov 2014 09:36:43 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f5-b7f956d000005ed7-4d-545c92a721b2 Date: Fri, 07 Nov 2014 09:36:39 +0000 From: Peter Stephenson To: Zsh workers Subject: Re: PATCH: keep region active when widget fails Message-id: <20141107093639.4fe68607@pwslap01u.europe.root.pri> In-reply-to: <8414.1415317703@thecus.kiddle.eu> References: <8414.1415317703@thecus.kiddle.eu> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e/4Zd3lk2JCDDYvVLU42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGWcOfGUs6GSpeDNnFlMD4yLmLkZODgkBE4kNy3tYIWwxiQv3 1rN1MXJxCAksZZS4/WwRC4SznEni5IznLCBVLAKqEg3zj4B1sAkYSkzdNJsRxBYBis85cQos LixgIdH6fD87iM0rYC+xYttHsDingL7ErMmLweYICehJ/J3bAmbzA8Wv/v3EBHGFvcTMK2cY IXoFJX5MvgdWwyygJbF5WxMrhC0vsXnNW+YJjAKzkJTNQlI2C0nZAkbmVYyiqaXJBcVJ6blG esWJucWleel6yfm5mxghQfh1B+PSY1aHGAU4GJV4eB+IxIQIsSaWFVfmHmKU4GBWEuFNbQQK 8aYkVlalFuXHF5XmpBYfYmTi4JRqYFx64dpCr+u39Vd++1FlnlVyMEpsT9tMk3l3UiNvv8s9 PUPK1MOt/Vdyl4qehdbKcpNP+cEJn9aVMJRx/ft4ZefekFZWldPvLr64sJtTe4f60hXHTySK Pl8fLHb6mdAbR9uv3UKzN/r93a+dPV1rZe0lgSsXjLTfdq2efNXH9NGRuqlHJPs2ac1WYinO SDTUYi4qTgQAn1g7JiACAAA= On Fri, 07 Nov 2014 00:48:23 +0100 Oliver Kiddle wrote: > Does anyone know why we set region_active to false in handlefeep()? I > would guess that there are perhaps cases where we want this but things > like cursor left when you're already in the first position shouldn't > unset region_active. Any objections to the following patch? We can > always add the assignment to individual widgets if we find cases where > it is desirable. That sounds OK --- I can't see any big problem. pws