zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: PRINT_TYPESET vs PRINT_WHENCE_CSH
Date: Sat, 8 Nov 2014 21:42:11 +0000	[thread overview]
Message-ID: <20141108214211.705fb2ac@pws-pc.ntlworld.com> (raw)
In-Reply-To: <141108124604.ZM19297@torch.brasslantern.com>

On Sat, 08 Nov 2014 12:46:04 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Either these sets of flags shouldn't overlap at all, or it shouldn't matter
> that they both start at (1<<0) ... or there's some reason to imply that
> whence and typeset are related?

I think I added PRINT_TYPESET in 2002 without looking at the others;
they should be kept separate for neatness though it doesn't actually
matter in practice since they apply to different types of node.

We seemed to lose bit 8 at some point.

diff --git a/Src/zsh.h b/Src/zsh.h
index d284c7a..031deaf 100644
--- a/Src/zsh.h
+++ b/Src/zsh.h
@@ -1865,9 +1865,9 @@ typedef groupset *Groupset;
 #define PRINT_TYPESET		(1<<5)
 
 /* flags for printing for the whence builtin */
-#define PRINT_WHENCE_CSH	(1<<5)
-#define PRINT_WHENCE_VERBOSE	(1<<6)
-#define PRINT_WHENCE_SIMPLE	(1<<7)
+#define PRINT_WHENCE_CSH	(1<<6)
+#define PRINT_WHENCE_VERBOSE	(1<<7)
+#define PRINT_WHENCE_SIMPLE	(1<<8)
 #define PRINT_WHENCE_FUNCDEF	(1<<9)
 #define PRINT_WHENCE_WORD	(1<<10)
 

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/


      reply	other threads:[~2014-11-08 21:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-08 20:46 Bart Schaefer
2014-11-08 21:42 ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141108214211.705fb2ac@pws-pc.ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).