From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17412 invoked by alias); 23 Nov 2014 21:53:49 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33786 Received: (qmail 22009 invoked from network); 23 Nov 2014 21:53:35 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Originating-IP: [86.6.25.230] X-Spam: 0 X-Authority: v=2.1 cv=dJgomYpb c=1 sm=1 tr=0 a=c0CwWhpM9oUd/BnC3z6Gzg==:117 a=c0CwWhpM9oUd/BnC3z6Gzg==:17 a=NLZqzBF-AAAA:8 a=5y4faFyK3SkA:10 a=2rnLKqsRDsbaxTOjgUkA:9 a=G6P0sg2J7h8A:10 a=nskYszS0UYQA:10 Message-Id: <201411232153.sANLrV8A004483@pws-pc.ntlworld.com> X-Authentication-Warning: pws-pc.ntlworld.com: pws owned process doing -bs From: Peter Stephenson To: zsh-workers@zsh.org Subject: Re: PATCH: Fix leaks of desthost in ztcp In-Reply-To: Message from Mikael Magnusson of "Sun, 23 Nov 2014 22:07:00 +0100." <1416776820-31394-1-git-send-email-mikachu@gmail.com> Date: Sun, 23 Nov 2014 21:53:31 +0000 Mikael Magnusson wrote: > Is that tcp_close right too? It's closed in another > error case nearby so I'm pretty sure it is. Looks right. We might want to make failures to close silent if we never passed back a successful open, but that's a different issue. pws