From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13120 invoked by alias); 9 Dec 2014 11:37:01 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33938 Received: (qmail 25524 invoked from network); 9 Dec 2014 11:36:57 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f4-b7f126d000001e9a-01-5486dc7a050e Date: Tue, 09 Dec 2014 11:26:47 +0000 From: Peter Stephenson To: Zsh Hackers' List Subject: Re: Interrupts in completion, traps in _main_complete Message-id: <20141209112647.3cc9f1d8@pwslap01u.europe.root.pri> In-reply-to: <141208204310.ZM5625@torch.brasslantern.com> References: <20141202155452.647182b4@pwslap01u.europe.root.pri> <141202084858.ZM31517@torch.brasslantern.com> <20141202172654.30e7d380@pwslap01u.europe.root.pri> <141204085606.ZM9146@torch.brasslantern.com> <20141204171226.301e9d2c@pwslap01u.europe.root.pri> <141205002023.ZM19736@torch.brasslantern.com> <20141205145054.655a2f70@pwslap01u.europe.root.pri> <141205100632.ZM508@torch.brasslantern.com> <20141205181330.2b458b46@pwslap01u.europe.root.pri> <20141205203417.2bc66b7b@pws-pc.ntlworld.com> <141206215911.ZM16010@torch.brasslantern.com> <20141207162157.27cf418f@pws-pc.ntlworld.com> <141207150140.ZM24076@torch.brasslantern.com> <20141208202717.46678b7d@pws-pc.ntlworld.com> <141208204310.ZM5625@torch.brasslantern.com> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsVy+t/xy7pVd9pCDKZMUbI42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGdc+NLIW7OOumHf8IlsD4xTOLkZODgkBE4k3B5tZIGwxiQv3 1rN1MXJxCAksZZR4fXkTWEJIYAmTRM87Xwh7G6PEq/NBIDaLgKrEzbVrGEFsNgFDiambZgPZ HBwiAtoS7R/FQMLCAnYSc648YAKxeQXsJd5ums4CUsIpYCnRut4PYtVnVolTbW/ZQGr4BfQl rv79xARxj73EzCtnGCF6BSV+TL4Hdg6zgJbE5m1NrBC2vMTmNW+ZIU5Tl7hxdzf7BEahWUha ZiFpmYWkZQEj8ypG0dTS5ILipPRcQ73ixNzi0rx0veT83E2MkID9soNx8TGrQ4wCHIxKPLzm iq0hQqyJZcWVuYcYJTiYlUR4pxxtCxHiTUmsrEotyo8vKs1JLT7EyMTBKdXAKPFD0bCn+e75 +9P2MGYKLC27VNb8yuOx5CI378UtEY9k/t01nb1E7/rmDMGYO1PMec9+2CCe1Pmccc4HNuad SSmrl/7VzYu1kvn1g/l8wI3UM7vXC2cuv3bxzjmmxYtfHVrlPpklMaFQ75veIo2apPUrKrUO FBrN+Nz0VuanCfsz1V+TM3bND1NiKc5INNRiLipOBABvw3+HNgIAAA== On Mon, 8 Dec 2014 20:43:10 -0800 Bart Schaefer wrote: > On Dec 8, 8:27pm, Peter Stephenson wrote: > } > } I'm probably missing a lot, but it struck me that if you're aborting out > } of completion completely, as it were, then the stuff that doesn't get > } executed doesn't typically matter all that much. The stuff you really > } want to get right on exit --- options, IFS, etc. --- is already local. > > I'm looking at LISTPROMPT, MENUPROMPT, MENUSCROLL, MENUSELECT, MENUMODE, > and ZLS_COLORS. Of which I guess only ZLS_COLORS gets reset right now, > but on an interrupt even it won't get restored. > > Incidentally, MENUMODE appears to be entirely undocumented. Apart from ZLE_COLORS it looks like we're not in imminent danger of making anything worse. I don't really understand what's going on with ZLE_COLORS, however. In the majority of cases it just seems to be saved and restored as if it were local. The only exception seems to be if the show-ambiguity style is set it gets saved for use in another completion. What is it about show-ambiguity that requires this? Is it so that if we redisplay a listing without going through _main_complete again it appears correct? I wonder if we're close to the point where applying this branch to the master is reasonable. It doesn't have to be 100% right, just good enough that people who use the bleeding edge don't fall flat on their faces. pws