From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1298 invoked by alias); 9 Dec 2014 11:50:54 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33939 Received: (qmail 519 invoked from network); 9 Dec 2014 11:50:52 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_PASS autolearn=ham version=3.3.2 X-AuditID: cbfec7f4-b7f126d000001e9a-1d-5486e21ade6d Date: Tue, 09 Dec 2014 11:50:41 +0000 From: Peter Stephenson To: Zsh Hackers' List Subject: Re: Interrupts in completion, traps in _main_complete Message-id: <20141209115041.08f4043b@pwslap01u.europe.root.pri> In-reply-to: <20141209112647.3cc9f1d8@pwslap01u.europe.root.pri> References: <20141202155452.647182b4@pwslap01u.europe.root.pri> <141202084858.ZM31517@torch.brasslantern.com> <20141202172654.30e7d380@pwslap01u.europe.root.pri> <141204085606.ZM9146@torch.brasslantern.com> <20141204171226.301e9d2c@pwslap01u.europe.root.pri> <141205002023.ZM19736@torch.brasslantern.com> <20141205145054.655a2f70@pwslap01u.europe.root.pri> <141205100632.ZM508@torch.brasslantern.com> <20141205181330.2b458b46@pwslap01u.europe.root.pri> <20141205203417.2bc66b7b@pws-pc.ntlworld.com> <141206215911.ZM16010@torch.brasslantern.com> <20141207162157.27cf418f@pws-pc.ntlworld.com> <141207150140.ZM24076@torch.brasslantern.com> <20141208202717.46678b7d@pws-pc.ntlworld.com> <141208204310.ZM5625@torch.brasslantern.com> <20141209112647.3cc9f1d8@pwslap01u.europe.root.pri> Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKLMWRmVeSWpSXmKPExsVy+t/xy7pSj9pCDO7vErU42PyQyYHRY9XB D0wBjFFcNimpOZllqUX6dglcGUuvTGYqmMdbMW/5LNYGxjNcXYycHBICJhIPH3ayQNhiEhfu rWfrYuTiEBJYyiix+tw+ZghnCZPEhv3LoDLbGCXW3d7KDtLCIqAqsf3SbVYQm03AUGLqptmM XYwcHCIC2hLtH8VAwsICdhJzrjxgArF5Bewl9h7qYgaxOQUcJJoPv2cEsYUEVrJJfNjpCWLz C+hLXP37iQniInuJmVfOMEL0Ckr8mHwP7FJmAS2JzduaWCFseYnNa94yQ8xRl7hxdzf7BEah WUhaZiFpmYWkZQEj8ypG0dTS5ILipPRcQ73ixNzi0rx0veT83E2MkKD9soNx8TGrQ4wCHIxK PLzmiq0hQqyJZcWVuYcYJTiYlUR4pxxtCxHiTUmsrEotyo8vKs1JLT7EyMTBKdXA6P9vxx+n vS4bPy46Yv3UgP9Y4/2M6C1LwmamBYlNvDOfX5dx6jS1hQfC5dflMz0qStDIc/GfeCxY1Gpx u+n6b6rb7+UK3Pjv0/5gJzvz9/vllzdzz79y027Zm2t7pzOpZzr4ei2R/JLLXPspS0w0hX3j pjnz792/o/l1QVXM0tWXrJ5O4Hsi4q3EUpyRaKjFXFScCACeBkAoOAIAAA== On Tue, 9 Dec 2014 11:26:47 +0000 Peter Stephenson wrote: > On Mon, 8 Dec 2014 20:43:10 -0800 > Bart Schaefer wrote: > > > On Dec 8, 8:27pm, Peter Stephenson wrote: > > } I'm probably missing a lot, but it struck me that if you're aborting out > > } of completion completely, as it were, then the stuff that doesn't get > > } executed doesn't typically matter all that much. The stuff you really > > } want to get right on exit --- options, IFS, etc. --- is already local. > > > > I'm looking at LISTPROMPT, MENUPROMPT, MENUSCROLL, MENUSELECT, MENUMODE, > > and ZLS_COLORS. Of which I guess only ZLS_COLORS gets reset right now, > > but on an interrupt even it won't get restored. > > I don't really understand what's going on with ZLE_COLORS, however. In > the majority of cases it just seems to be saved and restored as if it > were local. The only exception seems to be if the show-ambiguity style > is set it gets saved for use in another completion. What is it about > show-ambiguity that requires this? Is it so that if we redisplay a > listing without going through _main_complete again it appears correct? Came in in zsh-workers/12029, currently http://www.zsh.org/mla/workers/2000/msg02851.html I think the only relevant facts in the associated email are that colour handling "should be cleaner now" and that it should have been in a separate patch. The simultaneous change in _setup looks like it's relevant. It's been rewritten not to use ZLS_COLORS from before, but it will set the _comp_colors that subsequently gets saved into ZLS_COLORS. In summary: er, well, yeah. pws