From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers <zsh-workers@zsh.org>
Subject: Re: [BUG] Unicode variables can be exported and are exported metafied
Date: Thu, 18 Dec 2014 19:29:17 +0000 [thread overview]
Message-ID: <20141218192917.4df5324b@pws-pc.ntlworld.com> (raw)
In-Reply-To: <1054131418926765@web2o.yandex.ru>
On Thu, 18 Dec 2014 21:19:25 +0300
ZyX <kp-pav@yandex.ru> wrote:
> You see here that variable named `ус` can be exported (not sure
> whether it is a bug or not),
I *think* that's a "don't do that unless you actually need to..." but
feel free to present evidence otherwise.
> but its 0x83 byte which is the last byte of the first unicode
> codepoint that forms the variable name represented as UTF-8 is using
> zsh `Meta` escape in the `env` output (which clearly is a bug assuming
> the fact that unicode variable is exported is not).
Yes, indeed.
diff --git a/Src/params.c b/Src/params.c
index 79088d1..b87598a 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -4357,7 +4357,18 @@ arrfixenv(char *s, char **t)
int
zputenv(char *str)
{
+ char *ptr;
DPUTS(!str, "Attempt to put null string into environment.");
+ /*
+ * The environment uses NULL-terminated strings, so just
+ * unmetafy and ignore the length.
+ */
+ for (ptr = str; *ptr && *ptr != Meta; ptr++)
+ ;
+ if (*ptr == Meta) {
+ str = dupstring(str);
+ unmetafy(str, NULL);
+ }
#ifdef USE_SET_UNSET_ENV
/*
* If we are using unsetenv() to remove values from the
@@ -4366,7 +4377,6 @@ zputenv(char *str)
* Unfortunately this is a slightly different interface
* from what zputenv() assumes.
*/
- char *ptr;
int ret;
for (ptr = str; *ptr && *ptr != '='; ptr++)
pws
next prev parent reply other threads:[~2014-12-18 19:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 18:19 ZyX
2014-12-18 19:29 ` Peter Stephenson [this message]
2014-12-18 19:47 ` Peter Stephenson
2014-12-18 19:58 ` Bart Schaefer
2014-12-18 20:09 ` Peter Stephenson
[not found] ` <54933513.6010501@case.edu>
2014-12-18 20:20 ` Fwd: " Bart Schaefer
2014-12-19 9:29 ` Christoph (Stucki) von Stuckrad
2014-12-19 18:17 ` Christoph (Stucki) von Stuckrad
2014-12-19 20:13 ` Павлов Николай Александрович
2014-12-19 21:21 ` Peter Stephenson
2014-12-19 22:44 ` ZyX
2014-12-20 0:13 ` Stephane Chazelas
2014-12-20 9:27 ` ZyX
2014-12-20 10:08 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218192917.4df5324b@pws-pc.ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).