From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Re: Insecure tempfile creation
Date: Mon, 29 Dec 2014 00:49:57 +0000 [thread overview]
Message-ID: <20141229004957.GA1737@tarsus.local2> (raw)
In-Reply-To: <141228004101.ZM28486@torch.brasslantern.com>
Bart Schaefer wrote on Sun, Dec 28, 2014 at 00:41:01 -0800:
> On Dec 27, 11:44pm, Bart Schaefer wrote:
> }
> } I suppose =(<<<'') would actually be better, since it won't fork. Hm.
> }
> } This patch does not yet tackle uses of "/tmp" that do not use $TMPPREFIX
>
> Fortunately I didn't find any of the latter except for the previously
> identified one in _cvs (_cvs_run). So the patch below changes the use
> of =(:) to =(<<<'') and repairs _cvs_run to create the temp directory
> in a safe (I hope) manner. Apply on top of 34067.
>
First of all, thanks for picking this up. I'd meant to get back to this
thread early January, but I'm happy to have been beaten to it :-)
Your patches look good to me, including the rmdir, but except for:
> - } =(: temporary file)
> + } =(<<<'temporary file')
I assume =(<<<'') was the intention.
Thanks again,
Daniel
next prev parent reply other threads:[~2014-12-29 0:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 20:36 Daniel Shahaf
2014-12-22 22:01 ` Mikael Magnusson
2014-12-23 2:07 ` Bart Schaefer
2014-12-28 6:30 ` Bart Schaefer
2014-12-28 7:44 ` [PATCH] " Bart Schaefer
2014-12-28 8:41 ` Bart Schaefer
2014-12-29 0:49 ` Daniel Shahaf [this message]
2014-12-29 4:01 ` Bart Schaefer
2015-01-07 22:03 ` Daniel Shahaf
2015-01-08 6:22 ` Bart Schaefer
2015-01-08 6:48 ` Danek Duvall
2015-01-08 8:08 ` Bart Schaefer
2015-01-08 14:10 ` Daniel Shahaf
2015-01-08 14:24 ` Peter Stephenson
2015-01-08 16:35 ` Ray Andrews
2015-01-08 17:40 ` Peter Stephenson
2015-01-09 2:51 ` Mikael Magnusson
2015-01-09 9:02 ` Peter Stephenson
2015-01-09 12:51 ` Peter Stephenson
2015-01-09 13:35 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141229004957.GA1737@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).