PATCH: don't run zpty tests on Cygwin

PATCH: don't run zpty tests on Cygwin

[Peter Stephenson]

The tests otherwise ran here, but incredibly slowly, so the problem with
the kill didn't show up.  I didn't realise they could run that slowly.

diff --git a/Test/V08zpty.ztst b/Test/V08zpty.ztst
index 5b08fc2..b0cbfa0 100644
--- a/Test/V08zpty.ztst
+++ b/Test/V08zpty.ztst
@@ -6,7 +6,8 @@
   if ! zmodload zsh/zpty 2>/dev/null
   then
     ZTST_unimplemented="the zsh/zpty module is not available"
-    return 0
+  elif [[ $OSTYPE = cygwin ]]; then
+    ZTST_unimplemented="the zsh/zpty module does not work on Cygwin"
   fi
 
 %test
diff --git a/Test/Y01completion.ztst b/Test/Y01completion.ztst
index a2aa007..383e652 100644
--- a/Test/Y01completion.ztst
+++ b/Test/Y01completion.ztst
@@ -1,7 +1,9 @@
 # Tests for completion system.
 
 %prep
-  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
+  if [[ $OSTYPE = cygwin ]]; then
+    ZTST_unimplemented="the zsh/zpty module does not work on Cygwin"
+  elif ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
     . $ZTST_srcdir/comptest
     mkdir comp.tmp
     cd comp.tmp
diff --git a/Test/Y02compmatch.ztst b/Test/Y02compmatch.ztst
index 7045800..db734fa 100644
--- a/Test/Y02compmatch.ztst
+++ b/Test/Y02compmatch.ztst
@@ -11,7 +11,9 @@
 # contains the compadd output.
 
 %prep
-  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
+  if [[ $OSTYPE = cygwin ]]; then
+    ZTST_unimplemented="the zsh/zpty module does not work on Cygwin"
+  elif ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
     . $ZTST_srcdir/comptest
     mkdir match.tmp
     cd match.tmp
diff --git a/Test/Y03arguments.ztst b/Test/Y03arguments.ztst
index bfdcdec..0627104 100644
--- a/Test/Y03arguments.ztst
+++ b/Test/Y03arguments.ztst
@@ -1,7 +1,9 @@
 # Tests for _arguments.
 
 %prep
-  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
+  if [[ $OSTYPE = cygwin ]]; then
+    ZTST_unimplemented="the zsh/zpty module does not work on Cygwin"
+  elif ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
     . $ZTST_srcdir/comptest
     mkdir comp.tmp
     cd comp.tmp

pws

Re: PATCH: don't run zpty tests on Cygwin

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

Hi,

On Wed, Jan 14, 2015 at 3:32 PM, Peter Stephenson <p.stephenson@samsung.com>
wrote:

> The tests otherwise ran here, but incredibly slowly, so the problem with
> the kill didn't show up.  I didn't realise they could run that slowly.
>

How about disabling zpty compilation on Cygwin completely?

Thanks,
ismail

Re: PATCH: don't run zpty tests on Cygwin

[Peter Stephenson]

On Wed, 14 Jan 2015 15:48:18 +0200
İsmail Dönmez <ismail@donmez.ws> wrote:
> On Wed, Jan 14, 2015 at 3:32 PM, Peter Stephenson <p.stephenson@samsung.com>
> wrote:
> 
> > The tests otherwise ran here, but incredibly slowly, so the problem with
> > the kill didn't show up.  I didn't realise they could run that slowly.
> >
> 
> How about disabling zpty compilation on Cygwin completely?

From the mode of the failures I suspect it's not actually fundamentally
broken, so this seemed a bit drastic.  But given nobody is actually
likely to look at the problems (I might see how far I can get if I have
some spare time, but it's likely to reach a dead end quite quickly)
that's an option.

I doubt it's going to cause anyone else grief either way.

pws

Re: PATCH: don't run zpty tests on Cygwin

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On Wed, Jan 14, 2015 at 4:12 PM, Peter Stephenson <p.stephenson@samsung.com>
wrote:

> On Wed, 14 Jan 2015 15:48:18 +0200
> İsmail Dönmez <ismail@donmez.ws> wrote:
> > On Wed, Jan 14, 2015 at 3:32 PM, Peter Stephenson <
> p.stephenson@samsung.com>
> > wrote:
> >
> > > The tests otherwise ran here, but incredibly slowly, so the problem
> with
> > > the kill didn't show up.  I didn't realise they could run that slowly.
> > >
> >
> > How about disabling zpty compilation on Cygwin completely?
>
> From the mode of the failures I suspect it's not actually fundamentally
> broken, so this seemed a bit drastic.  But given nobody is actually
> likely to look at the problems (I might see how far I can get if I have
> some spare time, but it's likely to reach a dead end quite quickly)
> that's an option.
>
> I doubt it's going to cause anyone else grief either way.
>

This makes sense, you are right.

Re: PATCH: don't run zpty tests on Cygwin

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi again,

On Wed, Jan 14, 2015 at 3:32 PM, Peter Stephenson <p.stephenson@samsung.com>
wrote:

> The tests otherwise ran here, but incredibly slowly, so the problem with
> the kill didn't show up.  I didn't realise they could run that slowly.
>
>
X02zlevi.ztst is also hanging due to zpty.

Regards.

Re: PATCH: don't run zpty tests on Cygwin

[Peter Stephenson]

On Wed, 14 Jan 2015 19:10:51 +0200
İsmail Dönmez <ismail@donmez.ws> wrote:
> X02zlevi.ztst is also hanging due to zpty.

Missed that.

My own Cygwin test hasn't got that far in the last hour.  It's having
trouble forking processes.  Not ideal.

pws

diff --git a/Test/X02zlevi.ztst b/Test/X02zlevi.ztst
index 7bb35d5..6ca047d 100644
--- a/Test/X02zlevi.ztst
+++ b/Test/X02zlevi.ztst
@@ -1,7 +1,9 @@
 # Tests of the vi mode of ZLE
 
 %prep
-  if ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
+  if [[ $OSTYPE = cygwin ]]; then
+    ZTST_unimplemented="the zsh/zpty module does not work on Cygwin"
+  elif ( zmodload -i zsh/zpty ) >/dev/null 2>&1; then
     . $ZTST_srcdir/comptest
     comptestinit -v -z $ZTST_testdir/../Src/zsh
   else

Re: PATCH: don't run zpty tests on Cygwin

[İsmail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

On Wed, Jan 14, 2015 at 7:28 PM, Peter Stephenson <p.stephenson@samsung.com>
wrote:

> On Wed, 14 Jan 2015 19:10:51 +0200
> İsmail Dönmez <ismail@donmez.ws> wrote:
> > X02zlevi.ztst is also hanging due to zpty.
>
> Missed that.
>
> My own Cygwin test hasn't got that far in the last hour.  It's having
> trouble forking processes.  Not ideal.
>
>
Did you try installing 64bit Cygwin? It should not be that slow. For the
record you need http://cygwin.com/setup-x86_64.exe

ismail