zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] vcs_info: Documentation update
Date: Tue, 27 Jan 2015 10:03:34 +0000	[thread overview]
Message-ID: <20150127100334.GB1966@tarsus.local2> (raw)
In-Reply-To: <1422195649-625-1-git-send-email-ft@bewatermyfriend.org>

Frank Terbeck wrote on Sun, Jan 25, 2015 at 15:20:49 +0100:
> +item(tt(pre-addon-quilt))(
> +This hook is used when tt(vcs_info)'s quilt functionality is active in "addon"
> +mode (quilt used on top of a real version control system). It is activated
> +right before any quilt specific action is taken.
> +
> +Setting the `tt(ret)' variable in this hook to a non-zero value avoids the
> +quilt specific to be run at all.

Is a word missing here?
"quilt specific" → "quilt-specific action"

> From: Daniel Shahaf <d.s@daniel.shahaf.name>
> 
> This adds documentation for more hooks and styles available in
> vcs_info:
> 
>   - patch-format
>   - nopatch-format
>   - get-unapplied
>   - pre-addon-quilt
>   - set-patch-format
> ---

Thanks for finishing what I'd started, and for applying my patches so swiftly!

Daniel

P.S. Regarding the "TODO placeholders in documentation" issue: I didn't
intend to suggest using using the manual as a todo list.  I was only saying
that if we don't document the semantics of something, then documenting its
existence is better than not documenting it at all.  Sorry for not making
myself clear.


  reply	other threads:[~2015-01-27 10:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24 15:45 [PATCH] vcs_info docs: Document patch-format and more Daniel Shahaf
2015-01-25  0:50 ` Frank Terbeck
2015-01-25 14:20 ` [PATCH] vcs_info: Documentation update Frank Terbeck
2015-01-27 10:03   ` Daniel Shahaf [this message]
2015-01-27 20:08     ` [PATCH] vcs_info documentation: Fix wording Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150127100334.GB1966@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=ft@bewatermyfriend.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).