From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5227 invoked by alias); 27 Jan 2015 10:03:44 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34410 Received: (qmail 27318 invoked from network); 27 Jan 2015 10:03:41 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=x-sasl-enc:date:from:to:cc:subject :message-id:references:mime-version:content-type :content-transfer-encoding:in-reply-to; s=mesmtp; bh=zSiIydQhbmF LXJPEKvAuGV/KbNI=; b=lMMdeIi+jw5tNiuO+y/uxO5/+/CWQqmoQF5fNtEtEdi /Drk7QMtKBIC8fcSG2e1TtoovTwRxoFP6lnR0qk4aWHGad1dQIk/Sp8cHUJqiWtu aukQ3nblQ2O9zonxuDuFpdEZFB2t+lx1NSTRp6CcW4u3+Q1+Y2ZSoAgAFeHwETNk = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:date:from:to:cc:subject :message-id:references:mime-version:content-type :content-transfer-encoding:in-reply-to; s=smtpout; bh=zSiIydQhbm FLXJPEKvAuGV/KbNI=; b=EZg2IuuFtfXUATwCZJRaUO8Si67ACMEy3soKuo8OU2 yApU57ohZwspO2U8jOPRk1NzeNv/BXdsLbzKb6jUGeVS92MW48eavwE9Yufqoi1x ItJJN2hwBJ7/LsPl5sCYVP1Eq5bbP5i3+C9cWtCNZG+5x9M2N2m9Ut7lO5b8vPLB E= X-Sasl-enc: ImLsf0WMMVJ4EzghHxNMCgP/zBOrFxvRGbOYjyqSaf65 1422353016 Date: Tue, 27 Jan 2015 10:03:34 +0000 From: Daniel Shahaf To: Frank Terbeck Cc: zsh-workers@zsh.org Subject: Re: [PATCH] vcs_info: Documentation update Message-ID: <20150127100334.GB1966@tarsus.local2> References: <20150124154521.GF20359@tarsus.local2> <1422195649-625-1-git-send-email-ft@bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1422195649-625-1-git-send-email-ft@bewatermyfriend.org> User-Agent: Mutt/1.5.21 (2010-09-15) Frank Terbeck wrote on Sun, Jan 25, 2015 at 15:20:49 +0100: > +item(tt(pre-addon-quilt))( > +This hook is used when tt(vcs_info)'s quilt functionality is active in "addon" > +mode (quilt used on top of a real version control system). It is activated > +right before any quilt specific action is taken. > + > +Setting the `tt(ret)' variable in this hook to a non-zero value avoids the > +quilt specific to be run at all. Is a word missing here? "quilt specific" → "quilt-specific action" > From: Daniel Shahaf > > This adds documentation for more hooks and styles available in > vcs_info: > > - patch-format > - nopatch-format > - get-unapplied > - pre-addon-quilt > - set-patch-format > --- Thanks for finishing what I'd started, and for applying my patches so swiftly! Daniel P.S. Regarding the "TODO placeholders in documentation" issue: I didn't intend to suggest using using the manual as a todo list. I was only saying that if we don't document the semantics of something, then documenting its existence is better than not documenting it at all. Sorry for not making myself clear.