From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Fix use-after-free for print -zf and print -sf
Date: Tue, 10 Feb 2015 09:37:29 +0000 [thread overview]
Message-ID: <20150210093729.476bab46@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAHYJk3QWK-z-WA4-8EC_m+PYc8QACt_GPjNqC2FXqRQk4VF-xg@mail.gmail.com>
On Tue, 10 Feb 2015 08:16:56 +0100
Mikael Magnusson <mikachu@gmail.com> wrote:
> On Tue, Feb 10, 2015 at 8:12 AM, Mikael Magnusson <mikachu@gmail.com> wrote:
> > /* Testing EBADF special-cases >&- redirections */
> > - if ((fout != stdout) ? (fclose(fout) != 0) :
> > + if (fout && (fout != stdout) ? (fclose(fout) != 0) :
>
> Do I need an extra set of parens here? C precedence rules are fun.
>
https://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B#Operator_precedence
"&&" is higher precedence than && so this looks OK.
I suppose it's at the point where a lot of people would decide it needed
expanding into something clearer, but it's a reasonable extension of
what was there before. Can't see a problem with it.
pws
next prev parent reply other threads:[~2015-02-10 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 7:12 Mikael Magnusson
2015-02-10 7:16 ` Mikael Magnusson
2015-02-10 9:37 ` Peter Stephenson [this message]
2015-02-10 11:13 ` Mikael Magnusson
2015-02-10 11:18 ` Peter Stephenson
2015-02-10 11:32 ` Mikael Magnusson
2015-02-10 11:38 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210093729.476bab46@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).