zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: completion problem with '291' ok with '274'.
Date: Thu, 12 Feb 2015 09:25:36 +0000	[thread overview]
Message-ID: <20150212092536.74db3b50@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <150211213054.ZM19450@torch.brasslantern.com>

On Wed, 11 Feb 2015 21:30:54 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> So basically we have to back out all of 34485 and start that over.

Yes, it's job control stuff that the test suite doesn't cover.

The only completely safe way of fixing the print_exit_value problem
would be to duplicate that higher up.  We can restrict the effect of the
patch in other ways but it covers too much obscure stuff to be sure
about it.

Removing the tests in front of the "*cmplx = 1" must be safe in the
sense that if it shows up problems for annonymous functions then they're
already present in the standard execution path and hence need fixing.
However, with the rest of the change absent I'm not aware of remaining
side effects of this alone.

pws


  reply	other threads:[~2015-02-12  9:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 22:36 Ray Andrews
2015-02-11  2:35 ` Bart Schaefer
2015-02-11  3:39   ` Ray Andrews
2015-02-11  4:20     ` Bart Schaefer
2015-02-11  6:10       ` Ray Andrews
2015-02-11 16:28         ` Bart Schaefer
2015-02-11 17:40           ` Ray Andrews
2015-02-11 20:54             ` Bart Schaefer
2015-02-11 23:29               ` Ray Andrews
     [not found]                 ` <CAH+w=7Yx5FX4ZOB=EKbNULy86+Q+czDM-YA90-j3H=X4v2eS0w@mail.gmail.com>
     [not found]                   ` <54DC0675.4040808@eastlink.ca>
     [not found]                     ` <CAH+w=7YisQBt_UJLjv4pmohvE0BL9Wr0TFye9Kio=b4NxH5Niw@mail.gmail.com>
     [not found]                       ` <54DC34EF.4010204@eastlink.ca>
2015-02-12  5:30                         ` Bart Schaefer
2015-02-12  9:25                           ` Peter Stephenson [this message]
2015-02-12 16:43                             ` Bart Schaefer
2015-02-12 17:01                               ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150212092536.74db3b50@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).