zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: PATCH:  Crash bug on garbage input (previously reported to Debian)
Date: Sat, 14 Feb 2015 21:42:09 +0000	[thread overview]
Message-ID: <20150214214209.6d2f5e7e@ntlworld.com> (raw)
In-Reply-To: <150214102534.ZM4368@torch.brasslantern.com>

On Sat, 14 Feb 2015 10:25:34 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Garbage input (nul bytes, etc.) can cause the newly-introduced $(...)
> parser to become confused during look-ahead and back up the input too
> far before attempting a different parse.
> 
> The patch below simply detects the problem and turns it into a parse
> error with an appropriate warning.  It might be helpful to figure out
> how the confusion originates but this prevents the crash.

Hmmm... backup characters are simply matched with input characters.
Could it be something to do with multibyte?  If it's just invalid
characters, your fix is probably good enough in practice.  If it's a
problem with real multibyte characters we need to do more.e can

(I suspect we can do better with the jungle of input and history
character reading, which is a bit of a mess, though that's not really
relevant to the problem since I don't think the mess is causing any
problems in character counting.)

pws


  reply	other threads:[~2015-02-14 21:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-14 18:25 Bart Schaefer
2015-02-14 21:42 ` Peter Stephenson [this message]
2015-02-15 19:26   ` Bart Schaefer
2015-02-16 12:57     ` Peter Stephenson
2015-02-16 17:04       ` Peter Stephenson
2015-02-16 19:39         ` Bart Schaefer
2015-02-17 12:57           ` Peter Stephenson
2015-02-17 17:13             ` Bart Schaefer
2015-02-17  9:02         ` Mikael Magnusson
2015-02-17  9:39           ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150214214209.6d2f5e7e@ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).