From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8950 invoked by alias); 19 Feb 2015 22:08:54 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34577 Received: (qmail 9930 invoked from network); 19 Feb 2015 22:08:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Originating-IP: [86.6.153.127] X-Spam: 0 X-Authority: v=2.1 cv=UrbtNoAB c=1 sm=1 tr=0 a=39NrsSuza2clQiZR/7fYWQ==:117 a=39NrsSuza2clQiZR/7fYWQ==:17 a=IkcTkHD0fZMA:10 a=NLZqzBF-AAAA:8 a=pGLkceISAAAA:8 a=UE1p40ox9FtDmHbzUooA:9 a=QEXdDO2ut3YA:10 Date: Thu, 19 Feb 2015 22:03:11 +0000 From: Peter Stephenson To: "Zsh Hackers' List" Subject: Re: PATCH: parse from even deeper in hell Message-ID: <20150219220311.7dfdc4ec@ntlworld.com> In-Reply-To: References: <20150219101315.477f7f95@pwslap01u.europe.root.pri> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 19 Feb 2015 22:47:12 +0100 Mikael Magnusson wrote: > I get a crapton of "bad(2) wordsplit reading history:" with this > patch. It seems like all the failed lines have metafied characters in > them, if that's a hint. Most don't contain any syntax characters at > all, for example: > hist.c:3499: bad(2) wordsplit reading history: mp3info =E5=A5=BD=E3=81= =8D=E3=81=AB=E3=81=AA=E3=82=8A\M-c\M-^A=E3=81=84.mp3 > at: =E5=A5=BD=E3=81=8D=E3=81=AB=E3=81=AA=E3=82=8A\M-c\M-^A=E3=81=84.mp3s > word: =E5=A5=BD=E3=81=8D=E3=81=AB=E3=81=AA=E3=82=8A\M-c\M-^A=E3=81=84.mp3 Unless I'm missing something, I don't think you've said what the real characters you're expecting are. The broken ones aren't much use for testing. > The (2) means it's the second of the two bad=3D1; assignments > triggering. At line 3490? > I'm also not sure why the utf8 is slightly mishandled in the output > there. It has at least been unmetafied, the raw string in the history > file is more or less: > mp3info =E5=A5=BD=E3=81=83=EF=BF=BD=E3=81=AB=E3=81=AA=E3=82=83=EF=BF=BD= =E3=81=9F=E3=81=83=EF=BF=BD.mp3 So those aren't actually valid characters? Does that mean metafied characters are getting into the history? I've made it necessary for two more bytes to be metafied, so if the shell was expecting them to be metafied in the history file they won't be. The bytes are 0x9e and 0x9f. I guess we could special case those, but do we really output metafied characters to the history file? pws