From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: "Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: capturing output of !! not working
Date: Mon, 23 Mar 2015 21:34:26 +0000 [thread overview]
Message-ID: <20150323213426.21fd79c8@ntlworld.com> (raw)
In-Reply-To: <150322162235.ZM1728@torch.brasslantern.com>
On Sun, 22 Mar 2015 16:22:35 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Mar 22, 6:35pm, Peter Stephenson wrote:
> }
> } As I've noted in the comment, to get this stuff to work cleanly we need
> } to capture character-by-character input at a level over the history, but
> } we don't have one and there are probably too many levels anyway. So
> } this will have to do --- it's at least fairly obvious what's going on.
>
> OK, now we just need to do something similar for this:
>
> torch% alias '{'=echo
> torch% {bar
> zsh: command not found: echobar
> torch% fc -l
> 1 alias '{'=echo
> 2 {echobar
What appears to be happening here is that because there's no end of word
character after the expanded "{" we run straight onto the "bar" and only
call ihwend() via hwend() after that. As alias expansion is tied to
word-handling, we only then look at the test that resets the position in
the history line, which is too late.
I'm not sure how to fix this. Ideally, I think we'd handle not adding
the alias text to history the way we've been doing in other cases by
checking INP_* flags, which is much less hit and miss. That ought not
to be too difficult, but I haven't really got my mind round the
consequences yet.
Everything else I can think of is a bit of a hack (and surely we'd never
etc. etc.)
> Here's a test, which I have dropped in the previously-unused "W" category
> for "builtin interactive commands and constructs". If that doesn't seem
> correct, rename to D10history.
Looks fine. I'll try to expand it when it appears.
pws
next prev parent reply other threads:[~2015-03-23 21:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 1:49 Vin Shelton
2015-03-19 2:28 ` Bart Schaefer
2015-03-19 10:57 ` Peter Stephenson
2015-03-19 12:27 ` Vin Shelton
2015-03-19 12:53 ` Peter Stephenson
2015-03-20 10:57 ` Peter Stephenson
2015-03-20 16:04 ` Bart Schaefer
2015-03-22 18:35 ` Peter Stephenson
2015-03-22 19:18 ` Peter Stephenson
2015-03-22 23:22 ` Bart Schaefer
2015-03-23 21:34 ` Peter Stephenson [this message]
2015-03-24 0:54 ` Testing interactive features (Re: capturing output of !! not working) Bart Schaefer
2015-03-24 4:12 ` Bart Schaefer
2015-03-24 4:45 ` Bart Schaefer
2015-03-24 16:09 ` Bart Schaefer
2016-05-23 14:53 ` Mikael Magnusson
2015-03-25 15:48 ` PATCH: Removing aliases from history, 2015 style (was " Peter Stephenson
2015-03-25 17:57 ` PATCH: Removing aliases from history, 2015 style Peter Stephenson
2015-03-25 18:42 ` Mikael Magnusson
2015-03-27 10:06 ` Peter Stephenson
2015-03-27 15:25 ` Bart Schaefer
2015-03-27 15:41 ` Peter Stephenson
2015-03-27 17:17 ` Bart Schaefer
2015-03-27 17:47 ` Peter Stephenson
2015-03-29 18:38 ` Peter Stephenson
2015-03-25 18:58 ` Bart Schaefer
2015-03-25 19:40 ` PATCH: Removing aliases from history, 2015 style (was capturing output of !! not working) Bart Schaefer
2015-03-26 3:43 ` Word breaks around aliased tokens (was Re: PATCH: Removing aliases from history, 2015 style (was capturing output of !! not working)) Bart Schaefer
2015-03-30 18:04 ` Daniel Shahaf
2015-03-30 20:05 ` Mikael Magnusson
2015-03-30 18:08 ` Daniel Shahaf
2015-03-26 9:41 ` PATCH: Removing aliases from history, 2015 style (was capturing output of !! not working) Peter Stephenson
2015-03-26 15:22 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150323213426.21fd79c8@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).