From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34791-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 19117 invoked by alias); 27 Mar 2015 17:47:57 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34791
Received: (qmail 10357 invoked from network); 27 Mar 2015 17:47:46 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_HELO_PASS autolearn=ham version=3.3.2
X-AuditID: cbfec7f5-b7fc86d0000066b7-44-551597b9071e
Date: Fri, 27 Mar 2015 17:47:35 +0000
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: PATCH: Removing aliases from history, 2015 style
Message-id: <20150327174735.3cf69f6a@pwslap01u.europe.root.pri>
In-reply-to: <150327101701.ZM4220@torch.brasslantern.com>
References:
 <CACeGjnXH=Dk6eAv0OEfyT99RC9J=AMiyxL4wT4p_SVS1pLo0+g@mail.gmail.com>
 <20150319105716.620cd931@pwslap01u.europe.root.pri>
 <CACeGjnUxt0fZN2ArpV_8ECVF-_1KTtorO6rb11DzmOkOy3Xp4g@mail.gmail.com>
 <20150319125351.1e270c2d@pwslap01u.europe.root.pri>
 <20150320105703.2754b6af@pwslap01u.europe.root.pri>
 <150320090420.ZM21908@torch.brasslantern.com>
 <20150322183556.1fa0f143@ntlworld.com>
 <150322162235.ZM1728@torch.brasslantern.com>
 <20150323213426.21fd79c8@ntlworld.com>
 <20150325154853.7efc21d0@pwslap01u.europe.root.pri>
 <20150325175706.06cb1a8f@pwslap01u.europe.root.pri>
 <CAHYJk3Qtk5Y7sk86Q2=z=Nc3Bf3coOBD2uU5CsnRSWFQW7Hhjw@mail.gmail.com>
 <20150327100648.7f8d5aaa@pwslap01u.europe.root.pri>
 <150327082515.ZM4134@torch.brasslantern.com>
 <20150327154133.777b838e@pwslap01u.europe.root.pri>
 <150327101701.ZM4220@torch.brasslantern.com>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFlrCLMWRmVeSWpSXmKPExsVy+t/xq7o7p4uGGnRsl7I42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGc+WSRbsZKtY8X4nawNjC2sXIweHhICJxJe1mV2MnECmmMSF
	e+vZuhi5OIQEljJKfNu6nAnCWcIk8fb4T1YIZxujxMW1H9hAWlgEVCU2LZ/IBGKzCRhKTN00
	mxFkqoiAtkT7RzGQsLCArcSCfQvASngF7CX+HT8I1sopYCkxe+tydoiZL9kkTmz6zQ6S4BfQ
	l7j69xMTxEn2EjOvnGGEaBaU+DH5HguIzSygJbF5WxMrhC0vsXnNW2YQW0hAXeLG3d3sExiF
	ZiFpmYWkZRaSlgWMzKsYRVNLkwuKk9JzjfSKE3OLS/PS9ZLzczcxQkL26w7GpcesDjEKcDAq
	8fBy1ouECrEmlhVX5h5ilOBgVhLh3TBVNFSINyWxsiq1KD++qDQntfgQIxMHp1QDI3fN5JyX
	0WmMVj23pk32Plw2N1Vt47OvTetvB7o0yucHelZ4v1Ey8i4LD70qJuaVUTmn+8GrNsWrh1ff
	Uj1U2JXU+1qVz/ROttlvV41PvlH+e++l2t+W81t/y35vc8gLW5P3m+cfFWbj+PdH4996Pa31
	1sqs819HsiWbLlY8MW9f2Exu1uvGSizFGYmGWsxFxYkAGNk57TcCAAA=

On Fri, 27 Mar 2015 10:17:01 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Mar 27,  3:41pm, Peter Stephenson wrote:
> } Subject: Re: PATCH: Removing aliases from history, 2015 style
> }
> } On Fri, 27 Mar 2015 08:25:15 -0700
> } Bart Schaefer <schaefer@brasslantern.com> wrote:
> } > -    while (lexbuf.len > oldlen && !errflag) {
> } > +    while (lexbuf.len > oldlen && !(errflag & ERRFLAG_ERROR)) {
> } 
> } That doesn't seem to make a major difference --- I can't rule out the
> } possibility it perturbs the error messages a bit but they look similar
> } to the naked eye.
> 
> Seems like a reasonable thing to commit anyway?

Yes, it looks sensible --- it's basically like an "unwind protect" for
something we need to do on an interrupt.

There may be others like this lurking.

pws