zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] Use CC to determine if gcc is used
Date: Mon, 27 Apr 2015 18:09:09 +0100	[thread overview]
Message-ID: <20150427180909.52216530@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <553E6A65.7010809@heiko-becker.de>

On Mon, 27 Apr 2015 18:57:09 +0200
Heiko Becker <mail@heiko-becker.de> wrote:
> On 04/27/15 18:50, Peter Stephenson wrote:
> > On Mon, 27 Apr 2015 18:37:15 +0200
> > Please could you tell us what the underlying problem is (I mean that the
> > first patch was trying to fix)?  Then we can fix it properly.  All I
> > know is it fails somehow --- you said "miscompiled".  If we know how we
> > ought to be able to stop playing games with versions of CPP (presumably...)
> 
> Same problem as described here:
> http://www.zsh.org/mla/workers/2015/msg00211.html

OK, I've seen now --- the line markers are actually in the *middle* of
the output.  That's not going to work...  So it really is
gcc-specific; I can't imagine anything else is doing anything that
weird.

Simply removing the line markers won't work, then.  But from what I'm
seeing, the following probably ought to...

diff --git a/Src/zsh.mdd b/Src/zsh.mdd
index 71dd613..c2e59c9 100644
--- a/Src/zsh.mdd
+++ b/Src/zsh.mdd
@@ -28,8 +28,8 @@ hdrdeps="zshcurses.h zshterm.h"
 # on the option to remove them being the same.
 signames.c: signames1.awk signames2.awk ../config.h @SIGNAL_H@
 	$(AWK) -f $(sdir)/signames1.awk @SIGNAL_H@ >sigtmp.c
-	case "$(CPP)" in \
-	gcc*) \
+	case "`$(CPP) --version </dev/null 2>&1`" in \
+	*"Free Software Foundation"*) \
 	$(CPP) -P sigtmp.c >sigtmp.out;; \
 	*) \
 	$(CPP) sigtmp.c >sigtmp.out;; \


pws


  reply	other threads:[~2015-04-27 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-26 17:48 Heiko Becker
2015-04-27  8:47 ` Peter Stephenson
2015-04-27  9:07   ` Peter Stephenson
2015-04-27 13:30     ` Daniel Shahaf
2015-04-27 14:11       ` Peter Stephenson
2015-04-27 16:37         ` Heiko Becker
2015-04-27 16:50           ` Peter Stephenson
2015-04-27 16:57             ` Heiko Becker
2015-04-27 17:09               ` Peter Stephenson [this message]
2015-04-27 17:26                 ` Heiko Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150427180909.52216530@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).