From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-34982-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 18711 invoked by alias); 28 Apr 2015 08:35:15 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 34982
Received: (qmail 17777 invoked from network); 28 Apr 2015 08:35:04 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,
	SPF_HELO_PASS autolearn=ham version=3.3.2
X-AuditID: cbfec7f5-f794b6d000001495-e3-553f46382c79
Date: Tue, 28 Apr 2015 09:34:50 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Cc: Jared Ahern <jared.ahern@gmail.com>
Subject: Re: Proposed patches for make completion bugs
Message-id: <20150428093450.10bc6c0c@pwslap01u.europe.root.pri>
In-reply-to:
 <CA+80RYdqaKGNXE9J9gnT7uNcbmPmqoUHjw+w=N_+jwC+gm_7Lg@mail.gmail.com>
References: <CA+80RYdqaKGNXE9J9gnT7uNcbmPmqoUHjw+w=N_+jwC+gm_7Lg@mail.gmail.com>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xa7oWbvahBpN2cFt8nPCX3eJg80Mm
	ByaPnbPusnusOviBKYApissmJTUnsyy1SN8ugSujYadFwVm2ipNbG9gaGCexdjFyckgImEh8
	PXCLCcIWk7hwbz1bFyMXh5DAUkaJ+VOOM0M4DUwS8089ZwapEhLYxigxdWI2iM0ioCrRuugq
	2CQ2AUOJqZtmM4LYIgLiEmfXnmcBsZkF1CXmfmxhB7GFBcwkPvfOANvGK2Avse3UKrBeToFg
	iRvTW9kh5gdItKw/DtbLL6AvcfXvJ6jr7CVmXjnDCNErKPFj8j2o+VoSm7c1sULY8hKb17yF
	ulNd4sbd3ewTGIVnIWmZhaRlFpKWBYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCwvvr
	Dsalx6wOMQpwMCrx8BZw2YcKsSaWFVfmHmKU4GBWEuGttQUK8aYkVlalFuXHF5XmpBYfYpTm
	YFES5525632IkEB6YklqdmpqQWoRTJaJg1OqgVHje8qOw1HRP58r9vWmuwrvjKnwuuXGtL7G
	+qXeiWmZf31UdR7MrvxpUvtASjipb++c09VnGeY+SrBRjs3eHe7XtScoS2+JkpbknPtc9xqs
	pRjXJWr0ZJ+6/S7+ZhM713m+PboLLkitrGLnVUqXD4yye3XY+c4+1dOxmZynFWR+rk1mP9cg
	p8RSnJFoqMVcVJwIANNMthhrAgAA

On Mon, 27 Apr 2015 20:45:55 -0400
Jared Ahern <jared.ahern@gmail.com> wrote:
> The second issue is that as far as I can tell, expansion of "make"
> variables was not happening at all.  This should be addressed by this
> separate second patch, although I may have induced regressions of which I
> am unaware.  I wasn't 100% sure what the original intent was for the
> _make-expandVars function, but my cases appear to be fixed.

It's certainly hard to see how the old code could work...

  local open close var val front ret tmp=$1

  front=${tmp%%\$*}
  case $tmp in
    (\(*) # Variable of the form $(foobar)

... if tmp still has a $, how can matching it without a $ at the start
of the case be useful?  I'll assume this is an improvement and apply
both patches until someone comes up with a counterexample.

Thanks
pws