Test suite failures with 5.0.7-dev-2

Test suite failures with 5.0.7-dev-2

[Axel Beckert]

Hi,

while zsh 5.0.7-dev-2 built fine as Debian package locally on my
Debian Unstable amd64 (64 bit PC) laptop, as well as on i386[1] (32
bit PC) in a Debian Unstable chroot on our Jenkins server, it had test
suite failures[2] on amd64 in the Debian Unstable chroot on our
Jenkins server.

Copy and paste from the log, not necessarily with the correct amount
of whitespace:

Running test: Aliasing reserved tokens
Pattern match failed:
<begin
<end
<*4*{ begin
<*5*{end
>[1m[7m%[27m[1m[0m 
 
[1m[7m%[27m[1m[0m 
 
begin
>[1m[7m%[27m[1m[0m 
 
end
>[1m[7m%[27m[1m[0m 
 
    4    { begin
>    5    {end
>[1m[7m%[27m[1m[0m 
 
Test ../../Test/A02alias.ztst failed: output differs from expected as shown above for:
  $ZTST_testdir/../Src/zsh -fis <<<'
  PROMPT=""
  exec 2>&1
  alias \{=echo
  { begin
  {end
  fc -l -2' 2>/dev/null
Was testing: Aliasing reserved tokens
../../Test/A02alias.ztst: test failed.

This looks to me like failing due to additional ANSI escape sequences
in the output. (Currently no time for further investigations, sorry.
Maybe this evening.)

[1] http://jenkins.grml.org/view/Debian/job/zsh-binaries/architecture=i386/179/console
[2] http://jenkins.grml.org/view/Debian/job/zsh-binaries/architecture=amd64/180/console

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)

Re: Test suite failures with 5.0.7-dev-2

[Peter Stephenson]

On Wed, 6 May 2015 08:59:43 +0200
Axel Beckert <abe@deuxchevaux.org> wrote:
> Running test: Aliasing reserved tokens
> Pattern match failed:
> <begin
> <end
> <*4*{ begin
> <*5*{end
> >[1m[7m%[27m[1m[0m 
>..
> This looks to me like failing due to additional ANSI escape sequences
> in the output. (Currently no time for further investigations, sorry.
> Maybe this evening.)

Yes; does the following help?

pws

diff --git a/Test/A02alias.ztst b/Test/A02alias.ztst
index 08163eb..332e4e8 100644
--- a/Test/A02alias.ztst
+++ b/Test/A02alias.ztst
@@ -59,7 +59,7 @@
 >And aliases are expanded
 
   $ZTST_testdir/../Src/zsh -fis <<<'
-  PROMPT=""
+  PROMPT="" PS2="" PS3="" PS4="" RPS1="" RPS2=""
   exec 2>&1
   alias \{=echo
   { begin
@@ -72,7 +72,7 @@
 *>*5*{end
 
   $ZTST_testdir/../Src/zsh -fis <<<'
-  PROMPT=""
+  PROMPT="" PS2="" PS3="" PS4="" RPS1="" RPS2=""
   exec 2>&1
   alias -g S=\"
   echo S a string S "

Re: Test suite failures with 5.0.7-dev-2

[Axel Beckert]

Hi,

On Wed, May 06, 2015 at 09:42:57AM +0100, Peter Stephenson wrote:
> On Wed, 6 May 2015 08:59:43 +0200
> Axel Beckert <abe@deuxchevaux.org> wrote:
> > Running test: Aliasing reserved tokens
> > Pattern match failed:
> > <begin
> > <end
> > <*4*{ begin
> > <*5*{end
> > >[1m[7m%[27m[1m[0m 
> >..
> > This looks to me like failing due to additional ANSI escape sequences
> > in the output. (Currently no time for further investigations, sorry.
> > Maybe this evening.)
> 
> Yes; does the following help?

Unfortunately not:

http://jenkins.grml.org/view/Debian/job/zsh-binaries/architecture=amd64/181/console

And again the test only failed on amd64 and only in the chroot on the
Jenkins build server:

Running test: Aliasing reserved tokens
Pattern match failed:
<begin
<end
<*4*{ begin
<*5*{end
>[1m[7m%[27m[1m[0m 
 
[1m[7m%[27m[1m[0m 
 
begin
>[1m[7m%[27m[1m[0m 
 
end
>[1m[7m%[27m[1m[0m 
 
    4    { begin
>    5    {end
>[1m[7m%[27m[1m[0m 
 
Test ../../Test/A02alias.ztst failed: output differs from expected as shown above for:
  $ZTST_testdir/../Src/zsh -fis <<<'
  PROMPT="" PS2="" PS3="" PS4="" RPS1="" RPS2=""
  exec 2>&1
  alias \{=echo
  { begin
  {end
  fc -l -2' 2>/dev/null
Was testing: Aliasing reserved tokens
../../Test/A02alias.ztst: test failed.

In the meanwhile I also tried to reproduce the issue locally inside an
amd64 chroot, but without success: the test suite went through there
without issues.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)

Re: Test suite failures with 5.0.7-dev-2

[Axel Beckert]

Hi again,

On Wed, May 06, 2015 at 11:30:03PM +0200, Axel Beckert wrote:
> http://jenkins.grml.org/view/Debian/job/zsh-binaries/architecture=amd64/181/console
> 
> And again the test only failed on amd64 and only in the chroot on the
> Jenkins build server:

Actually it failed on amd64 and then the i386 job never seem to have
started. So all the test suite failure instances I reported this week
may not be architecture-specific.

Another set of details which shows that the prompt variables don't
seem to cause these issues is contained in the log of a modified built
which calls "printenv" before running the test suite:

http://jenkins.grml.org/view/Debian/job/zsh-binaries/architecture=amd64/182/console

HTH.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)

Re: Test suite failures with 5.0.7-dev-2

[Peter Stephenson]

On Wed, 6 May 2015 23:30:03 +0200
Axel Beckert <abe@deuxchevaux.org> wrote:
> On Wed, May 06, 2015 at 09:42:57AM +0100, Peter Stephenson wrote:
> > On Wed, 6 May 2015 08:59:43 +0200
> > Axel Beckert <abe@deuxchevaux.org> wrote:
> > > Running test: Aliasing reserved tokens
> > > Pattern match failed:
> > > <begin
> > > <end
> > > <*4*{ begin
> > > <*5*{end
> > > >[1m[7m%[27m[1m[0m 
> > >..
> > > This looks to me like failing due to additional ANSI escape sequences
> > > in the output. (Currently no time for further investigations, sorry.
> > > Maybe this evening.)
> > 
> > Yes; does the following help?
> 
> Unfortunately not:

Hmm...  If that '[1m[7m%[27m[1m[0m ' isn't coming from a prompt of some
sort I'll eat my hat.  An inverse video percent (once you've put the
escapes back) with a space after it can't really be anything else.

Something in your set up must be doing that.  Have you an /etc/zshenv in
there?

pws

Re: Test suite failures with 5.0.7-dev-2

[Axel Beckert]

Hi,

On Thu, May 07, 2015 at 09:33:17AM +0100, Peter Stephenson wrote:
> Hmm...  If that '[1m[7m%[27m[1m[0m ' isn't coming from a prompt of some
> sort I'll eat my hat.  An inverse video percent (once you've put the
> escapes back) with a space after it can't really be anything else.

You've got a point there. And thanks for the parsing of the ANSI
sequences. :-)

An inverse percent sign sounds like an command output which didn't end
in a newline... Hrm.

> Something in your set up must be doing that.

That should be a freshly setup clean Debian Unstable chroot upon every
build. But something must be indeed different to my local clean Debian
Unstable chroot as it doesn't happen there.

> Have you an /etc/zshenv in there?

Not that I know.

I'll investigate further later today.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)

Re: Test suite failures with 5.0.7-dev-2

[Peter Stephenson]

On Thu, 7 May 2015 15:32:27 +0200
Axel Beckert <abe@deuxchevaux.org> wrote:
> An inverse percent sign sounds like an command output which didn't end
> in a newline... Hrm.

PWS [smacks forehead making the following sound]:  Ahhhhhrmgrggh.

That suggests something got a bit split up in some unhelpful way, so I'm
not sure if the following is going to be good enough, but try it anyway.

pws

diff --git a/Test/A02alias.ztst b/Test/A02alias.ztst
index 08163eb..cace2a4 100644
--- a/Test/A02alias.ztst
+++ b/Test/A02alias.ztst
@@ -59,7 +59,8 @@
 >And aliases are expanded
 
   $ZTST_testdir/../Src/zsh -fis <<<'
-  PROMPT=""
+  unsetopt PROMPT_SP
+  PROMPT="" PS2="" PS3="" PS4="" RPS1="" RPS2=""
   exec 2>&1
   alias \{=echo
   { begin
@@ -68,16 +69,17 @@
 0:Aliasing reserved tokens
 >begin
 >end
-*>*4*{ begin
-*>*5*{end
+*>*5*{ begin
+*>*6*{end
 
   $ZTST_testdir/../Src/zsh -fis <<<'
-  PROMPT=""
+  unsetopt PROMPT_SP
+  PROMPT="" PS2="" PS3="" PS4="" RPS1="" RPS2=""
   exec 2>&1
   alias -g S=\"
   echo S a string S "
   fc -l -1' 2>/dev/null
 0:Global aliasing quotes
 > a string S 
-*>*4*echo S a string S "
+*>*5*echo S a string S "
 # Note there is a trailing space on the "> a string S " line

Re: Test suite failures with 5.0.7-dev-2

[Axel Beckert]

Hi Peter,

On Thu, May 07, 2015 at 02:55:26PM +0100, Peter Stephenson wrote:
> On Thu, 7 May 2015 15:32:27 +0200
> Axel Beckert <abe@deuxchevaux.org> wrote:
> > An inverse percent sign sounds like an command output which didn't end
> > in a newline... Hrm.
> 
> PWS [smacks forehead making the following sound]:  Ahhhhhrmgrggh.

:-)

> That suggests something got a bit split up in some unhelpful way, so I'm
> not sure if the following is going to be good enough, but try it anyway.

This worked and the package built fine on amd64 as well as on i386 inside
the Jenkins:
http://jenkins.grml.org/view/Debian/job/zsh-binaries/183/architecture=amd64/console

Thanks!

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)