From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16221 invoked by alias); 16 May 2015 22:54:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35160 Received: (qmail 15661 invoked from network); 16 May 2015 22:54:27 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=XnP7jlfzrLwhG4p+ OzQ0f3BrHeo=; b=EkegSHZtceLR/TZsGRrls6GJ9z5cgE0FQaR+aNakoNr5FB37 hVgn/qF6qTHrzEbUcJWyEW3tW5dGltj0j8//6lNlzQpu58BNlbZ2ri4EzlmIVyYz S/H9619phSCituCD4tCpzd0/17ReEhNUy51+eURpysbSirhIsNQqFDGR3Ik= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=XnP7jlfzrLwhG4p +OzQ0f3BrHeo=; b=cpqD0N5CJsADxOmftN4d+dMa7QaNzt0klS0ZG7Wo6sUf4EP exiZiLKJDnRxBz1xuJdmzbVJ9grga4ntyeWs4N4y+S6bdop/0duYX1kF/mlaDSW6 eqNcZcnEasjWbsgdjfHp7aQU9QUtRxu6aDlMKFkJpigMJX2sceNMsJYP7boE= X-Sasl-enc: 38l25/Iq2RITApJKDaDkcRgSnocdcQwGTd+YDZNpT253 1431816864 Date: Sat, 16 May 2015 22:54:22 +0000 From: Daniel Shahaf To: Zsh Hackers' List Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) (was: Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects) Message-ID: <20150516225422.GH1976@tarsus.local2> References: <5510AAD4.8040807@thequod.de> <20150329054753.GA2766@tarsus.local2> <20150514143627.GE1932@tarsus.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150514143627.GE1932@tarsus.local2> User-Agent: Mutt/1.5.21 (2010-09-15) Daniel Shahaf wrote on Thu, May 14, 2015 at 14:36:27 +0000: > The first attached patch seems to address this. However, I encountered > an odd problem with it, which I have not been able to narrow down. When > I apply the first patch, Daniel Hahler's recent series, and the second > attached patch, and then try to complete 'git checkout 1',¹ I get > first a screenful of hashes, and then a screenful of descriptions, and > so on alternating. I'm not sure whether this indicates a bug in the > first patch or an independent problem. To be explicit: the problem goes away if I revert the first patch, but keep the others applied. None of the other patches touch any C code or anything remotely related to the _describe internals.