zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: vim completion problem after workers/35168
Date: Mon, 18 May 2015 12:40:39 +0100	[thread overview]
Message-ID: <20150518124039.0160a3bb@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAJ1KOAhWcNN-F7jXgo0vCc+ioR2d09_f1Np9EWf0TS+rZ-fkkw@mail.gmail.com>

On Mon, 18 May 2015 14:22:20 +0300
İsmail Dönmez <ismail@donmez.ws> wrote:
> Unfortunately even after 35184 I get an error:
> 
> _vim:7: parse error near `)'
> 
> yeah this time its the right parentheses :)

A slightly closer examination reveals the following...

Yet another annoyance: in the old hack, you got away with having a
pattern beginning with "(" (and containing balanced parentheses)
followed by an unbalanced ")".  Now you don't.  I don't think that's
actually *that* unfair, and looking at the context below it was clearly
just a mistake in this case.

pws

diff --git a/Completion/Unix/Command/_vim b/Completion/Unix/Command/_vim
index 021054d..007671b 100644
--- a/Completion/Unix/Command/_vim
+++ b/Completion/Unix/Command/_vim
@@ -4,7 +4,7 @@
 _vim_files () {
   case $PREFIX in
     (+*) _files -P './' $* && return 0 ;;
-    (scp|http(|s)|(|s)ftp):*) _urls ;;
+    ((scp|http(|s)|(|s)ftp):*) _urls ;;
     (*) _files $* ;;
   esac
   case $PREFIX in


  reply	other threads:[~2015-05-18 11:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 10:29 İsmail Dönmez
2015-05-18 10:53 ` Peter Stephenson
2015-05-18 11:22   ` İsmail Dönmez
2015-05-18 11:40     ` Peter Stephenson [this message]
2015-05-18 11:42       ` İsmail Dönmez
2015-05-19  0:30       ` Bart Schaefer
2015-05-19  1:34         ` Daniel Shahaf
2015-05-19  8:44           ` Peter Stephenson
2015-05-19  6:34         ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518124039.0160a3bb@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).