zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: "{ } always { }" construct and return in called functions
Date: Mon, 18 May 2015 13:14:01 +0100	[thread overview]
Message-ID: <20150518131401.2db3aefa@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAHYJk3RBn_U_ZTNXWHeBfAJyibspcx1=gMM2OTmXz2cpsrrY2Q@mail.gmail.com>

On Mon, 18 May 2015 13:38:15 +0200
Mikael Magnusson <mikachu@gmail.com> wrote:
> This patch breaks my setup.
> 
> # Some hooks into accept-line
> if [[ -n "$ZSHRUN" ]]; then
>   unsetopt correct
>   function _accept_and_quit() {
>   local -a buf
>   buf=(${(z)BUFFER})
>   if which $buf[1] >& /dev/null; then
>     zsh -c "${BUFFER}" &|
>     exit
>   else
>     zle -M "Command $buf[1] not found"
>   fi
>   }
>   zle -N _accept_and_quit
>   bindkey "^M" _accept_and_quit
> fi
> 
> With the patch, commands are randomly ran two or three times instead
> of just once in the background. AFAIK there are no always blocks
> involved in this part of my rc.

Are you actually trying to exit from the main shell here?  It claims to
be a hook into accept-line but it doesn't look to me like it is.

The key here is presumably sorting out what functions are running at
what level, i.e. where the "exit" command is first run and where the
shell actually exits (you could trying adding a message after "exit" to
see if that gets run, though that probably won't help since "retflag" is
likely to be set at that point).  In particular, what should happen is
the code at the end of doshfunc() causes the shell to exit at the end of
_accept_and_quit.  The simpler the case, the more likely
the relationship is to come out.

pws


  reply	other threads:[~2015-05-18 12:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAHfspHmUOgLjnEMtLBBoeU31Z2GKu8uD5MYE4jsogMKbf+ag9g@mail.gmail.com>
     [not found] ` <20150513155915.71f3daaa@pwslap01u.europe.root.pri>
2015-05-18 11:38   ` Mikael Magnusson
2015-05-18 12:14     ` Peter Stephenson [this message]
2015-05-18 12:24       ` Mikael Magnusson
2015-05-18 12:47         ` Peter Stephenson
2015-05-19  5:04           ` Bart Schaefer
2015-05-19  6:22             ` Mikael Magnusson
2015-05-19  6:31               ` Mikael Magnusson
2015-05-20 17:31               ` Bart Schaefer
2015-05-22 22:31     ` Peter Stephenson
2015-05-22 22:46       ` Bart Schaefer
2015-05-23 10:49       ` Daniel Shahaf
2015-05-23 15:13       ` Mikael Magnusson
2015-05-27  2:20         ` Dave Yost
2015-05-30  0:31           ` Bang-four (Re: "{ } always { }" construct and return in called functions) Bart Schaefer
2015-05-23 22:32       ` Release blocker (was: " Daniel Hahler
2015-05-24 12:54         ` Peter Stephenson
2015-05-26  9:03           ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518131401.2db3aefa@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).