From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: "{ } always { }" construct and return in called functions
Date: Mon, 18 May 2015 13:47:04 +0100 [thread overview]
Message-ID: <20150518134704.0a7f4293@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <CAHYJk3QCxkpN_G2yAXW0S+J8BnV4O3OFTpPHAg9+ajuJ3RXb1A@mail.gmail.com>
On Mon, 18 May 2015 14:24:51 +0200
Mikael Magnusson <mikachu@gmail.com> wrote:
> I would have expected the shell to exit when encountering the "exit"
> command, and run no further commands, no matter the circumstances.
> Probably a naive viewpoint considering all I've seen. I've reverted
> the patch locally for now, but I might investigate more later then.
bin_break(), which handles exit, says:
case BIN_EXIT:
if (locallevel > forklevel) {
/*
* We don't exit directly from functions to allow tidying
* up, in particular EXIT traps. We still need to perform
* the usual interactive tests to see if we can exit at
* all, however.
*
* If we are forked, we exit the shell at the function depth
* at which we became a subshell, hence the comparison.
*/
if (stopmsg || (zexit(0,2), !stopmsg)) {
retflag = 1;
breaks = loops;
exit_pending = (num << 1) | 1;
exit_level = locallevel;
}
} else
zexit(num, 0);
break;
"always" blocks are another form of tidy up that may or may not apply:
we're too deep here to know whether they do or not.
But there's nothing in the code in doshfunc() that should prevent the exit
happening there, unless there's some fork()ing going on that isn't
obvious. We need to work out what path it's taking through both chunks
of code (some fprintf's might be good enough).
Hmmm... I'm wondering if the fact you've started jobs is important. It
shouldn't be, with the "&|", and the doshfunc() code is supposed
to make it irrelevant anyway by setting "stopmsg = 1".
pws
next prev parent reply other threads:[~2015-05-18 12:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHfspHmUOgLjnEMtLBBoeU31Z2GKu8uD5MYE4jsogMKbf+ag9g@mail.gmail.com>
[not found] ` <20150513155915.71f3daaa@pwslap01u.europe.root.pri>
2015-05-18 11:38 ` Mikael Magnusson
2015-05-18 12:14 ` Peter Stephenson
2015-05-18 12:24 ` Mikael Magnusson
2015-05-18 12:47 ` Peter Stephenson [this message]
2015-05-19 5:04 ` Bart Schaefer
2015-05-19 6:22 ` Mikael Magnusson
2015-05-19 6:31 ` Mikael Magnusson
2015-05-20 17:31 ` Bart Schaefer
2015-05-22 22:31 ` Peter Stephenson
2015-05-22 22:46 ` Bart Schaefer
2015-05-23 10:49 ` Daniel Shahaf
2015-05-23 15:13 ` Mikael Magnusson
2015-05-27 2:20 ` Dave Yost
2015-05-30 0:31 ` Bang-four (Re: "{ } always { }" construct and return in called functions) Bart Schaefer
2015-05-23 22:32 ` Release blocker (was: " Daniel Hahler
2015-05-24 12:54 ` Peter Stephenson
2015-05-26 9:03 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518134704.0a7f4293@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).