From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20941 invoked by alias); 19 May 2015 20:41:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 35225 Received: (qmail 28968 invoked from network); 19 May 2015 20:41:23 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=z6eFAgpkD8j/yjyH wNtDE4kFAfk=; b=Xj8/oRnpDY6fFppAy9LPu/vIjhwWOtPtfXuYTrVxHlgCbf2D aSGFSYt2fiNx0L03JePZYpQnZ0SUdbE4Fx/Ug4qFt3ndAQNR9lopHMZqHPGq7Jou i/ekbogBFITz6Ew86Oo9hkGB1WchdkNaIfbq6FiXTbwp01yUblJWEMc5Qhc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=z6eFAgpkD8j/yjy HwNtDE4kFAfk=; b=qVzWMVRIxCgOe9QGg9/N9fPO3bDh/nuaWtPBDr+JeQe8tyt WNEFbTHEMTKMDUyeUiPQuSyl39VqTiU9ptXsEbcB5+S/DNA+n628gQVeTNNRQmRu SrPQZz88qCTdiLb/RpA5Qern6qMKROCm0QDgMRAqiC87iHZJ4hdccoesRbwE= X-Sasl-enc: dpbtX/PiS0TsINI27GZDtQ6ikH8Tr7g9g93ZaEx+QWyp 1432068081 Date: Tue, 19 May 2015 20:41:19 +0000 From: Daniel Shahaf To: Bart Schaefer Cc: Zsh Hackers' List Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) (was: Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects) Message-ID: <20150519204119.GB1837@tarsus.local2> References: <5510AAD4.8040807@thequod.de> <20150329054753.GA2766@tarsus.local2> <20150514143627.GE1932@tarsus.local2> <20150516225422.GH1976@tarsus.local2> <150516210736.ZM4220@torch.brasslantern.com> <20150517234059.GF2214@tarsus.local2> <150517210027.ZM845@torch.brasslantern.com> <20150519013631.GB2024@tarsus.local2> <150518213714.ZM6895@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <150518213714.ZM6895@torch.brasslantern.com> User-Agent: Mutt/1.5.21 (2010-09-15) Bart Schaefer wrote on Mon, May 18, 2015 at 21:37:14 -0700: > On May 19, 1:36am, Daniel Shahaf wrote: > } Subject: Re: [PATCH] compdescribe fix for unsorted groups (workers/34814) > } > } You tried to complete 'git checkout 1'. The bug reproduces when > } I do 'git checkout ', i.e., space-tab, not space-digitone-tab. > > OK; I was just trying to repeat what you said in 35127: > > I apply the first patch, Daniel Hahler's recent series, and the second > > attached patch, and then try to complete 'git checkout 1',¹ I get > > first a screenful of hashes, and then a screenful of descriptions, and > > I now realize that you don't mean "a screenful of ######" but rather a > screenful of git checksums. I've been looking all this time for some > sort of horrible memory scrambling that was filling your screen with > garbage. Sigh. Sorry about the miscommunication. I see my original phrasing was ambiguous. I don't understand why 35169 didn't resolve the ambiguity (that post includes a verbatim copy of the garbled output). > So ... 35127 deletes/disregards this comment: > > - # Note: the after-the-colon part must be unique across the entire array; > - # see workers/34768 > > It then proceeds to add two completions for each description. The problem > described in 34768 kicks in, and you get the results you observed. The second patch in 35127 deliberately triggers the condition the being-removed comment states is buggy, to prove that the first patch in 35127 fixes that particular bug. The issue is now resolved; I'll write a separate email with details. (Spoiler: 35127 is correct when applied on top of 35216.) Again, sorry for the miscommunication, and thanks for the help. Daniel